webadmin-devel

[webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Christophe C. <chr...@pu...>]

A new feature in webmin 1.170 is to send mail to users near their quota
http://webmin.com/changes-1.170.html

I think displaying a column with the % quota used is usefull,
and displaying them in red if they're above some limit (ex 70%)

For webmin 1.160, I choosed hard quota % and wrote patches for it.
See my previous mail [1] on web...@li...

I didnt receive any response, but I didnt choose right list.
So I rewrote patches (diff -u) for webmin 1.170, in attachment.

What do you think about it? Could this be added in next webmin release?
If not, what should be improved?

----

Christophe

[1] Quota module idea : percentage used and threshold -- 2004-10-01 02:20
http://sourceforge.net/mailarchive/forum.php?thread_id=5683080&forum_id=3156

Re: [webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Jamie C. <jca...@we...>]

On Sat, 2004-11-20 at 01:08, Christophe Chisogne wrote:
> A new feature in webmin 1.170 is to send mail to users near their quota
> http://webmin.com/changes-1.170.html
> 
> I think displaying a column with the % quota used is usefull,
> and displaying them in red if they're above some limit (ex 70%)
> 
> For webmin 1.160, I choosed hard quota % and wrote patches for it.
> See my previous mail [1] on web...@li...
> 
> I didnt receive any response, but I didnt choose right list.
> So I rewrote patches (diff -u) for webmin 1.170, in attachment.
> 
> What do you think about it? Could this be added in next webmin release?
> If not, what should be improved?

That sounds like a good patch - I must have missed it when it was first
sent to the list. Could you email a diff file to me, and I will
incorporate it into the next release if it looks good ..

 - Jamie

Re: [webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Christophe C. <chr...@pu...>]

Jamie Cameron wrote:
> Could you email a diff file to me

Oops, I forgot attachments in my previous mail, sorry.
Here are the files from quota dir (simply made with 'diff -u').

I'm not (yet) familiar with patch management. But if you tell me
how to do it better, I'll try to do it next time
(yes, I should first read man pages about diff, patch etc)

> incorporate it into the next release if it looks good ..

I simply added a column (% quota used) and a new option to choose
the level (x%) above which quota is showed in red. Feel free to
improve it, as I'm not a Perl hacker, not even a native speaker ;)

Christophe

Re: [webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Jamie C. <jca...@we...>]

On Mon, 2004-11-22 at 20:19, Christophe Chisogne wrote:
> Jamie Cameron wrote:
> > Could you email a diff file to me
> 
> Oops, I forgot attachments in my previous mail, sorry.
> Here are the files from quota dir (simply made with 'diff -u').
> 
> I'm not (yet) familiar with patch management. But if you tell me
> how to do it better, I'll try to do it next time
> (yes, I should first read man pages about diff, patch etc)
> 
> > incorporate it into the next release if it looks good ..
> 
> I simply added a column (% quota used) and a new option to choose
> the level (x%) above which quota is showed in red. Feel free to
> improve it, as I'm not a Perl hacker, not even a native speaker ;)
> 
> Christophe

Thanks for that patch - I will include it in the next Webmin release.

 - Jamie

Re: [webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Martin M. <mm...@me...>]

Hello,

Christophe Chisogne <chr...@pu...> wrote :

> Oops, I forgot attachments in my previous mail, sorry.
> Here are the files from quota dir (simply made with 'diff -u').

Is there are diff for confi.info available?
I am not sure if Jamie is able to read french ;-)

bis dahin - kind regards

Martin Mewes

-- 
Member of the Webmin Translation Team
http://www.webmin.com/	http://webmin.mamemu.de/
Debian, SuSE, Securityfocus and Webmin - Mailinglist mboxes
http://www.mewes.tv/mbox/

Re: [webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Christophe C. <chr...@pu...>]

Martin Mewes wrote:
> Is there are diff for confi.info available?

yes, it was in attach -- config.info.path-1.170
Seems I should really choose better filenames.

> I am not sure if Jamie is able to read french ;-)

You're right. I made changes for both English and French,
but perhaps I should only send the English versions.

btw I guess I could send french translations to
web...@ma... if I see some strings untranslated.
but I dont have too much time to do it now.

Please dont mail me in German or Japanase in retalliation
;-)

Christophe

Re: [webmin-devel] [patch] quotas : % used with limit, for webmin 1.170

[Martin M. <mm...@me...>]

Hi Christophe,

Christophe Chisogne <chr...@pu...> wrote :

> btw I guess I could send french translations to
> web...@ma... if I see some strings untranslated.
> but I dont have too much time to do it now.

If you wanna send updates <mailto:tra...@we...> ;-)

Rule 01: use wbmtranslator
Rule 02: use wbmtranslator
Rule 03: use wbmtranslator ;-)

bis dahin - kind regards

Martin Mewes

-- 
Member of the Webmin Translation Team
http://www.webmin.com/	http://webmin.mamemu.de/
Debian, SuSE, Securityfocus and Webmin - Mailinglist mboxes
http://www.mewes.tv/mbox/