webadmin-devel

[webmin-devel] Backup Configuration Module

[Martin M. <mm...@me...>]

Dear Jamie,

this is what happens when I try to invoke the Backup Module for Configuration Data.

> Fehler
> -----
> require bind8/backup_config.pl failed : <pre>syntax error at /usr/libexec/webmin/bind8/backup_config.pl
> line 61, near ") {"
> syntax error at /usr/libexec/webmin/bind8/backup_config.pl line 65, near
> "}"
> </pre>
> -----

Looking at the code

# post_restore(&files)
# Called after the files are restored from a backup
sub post_restore
{
local $pidfile = &get_pid_file();
if (&check_pid_file(&make_chroot($pidfile)) {
        return &restart_bind();
        }
return undef;
}

I think it should be

if (&check_pid_file(&make_chroot($pidfile))) {

because you open three '(' but only closing two ')'

I manually changed the code and after a test at my place everything works ok now.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] Backup Configuration Module

[Jamie C. <jca...@we...>]

On Wed, 2004-10-13 at 16:23, Martin Mewes wrote:
> Dear Jamie,
> 
> this is what happens when I try to invoke the Backup Module for Configuration Data.
> 
> > Fehler
> > -----
> > require bind8/backup_config.pl failed : <pre>syntax error at /usr/libexec/webmin/bind8/backup_config.pl
> > line 61, near ") {"
> > syntax error at /usr/libexec/webmin/bind8/backup_config.pl line 65, near
> > "}"
> > </pre>
> > -----
> 
> Looking at the code
> 
> # post_restore(&files)
> # Called after the files are restored from a backup
> sub post_restore
> {
> local $pidfile = &get_pid_file();
> if (&check_pid_file(&make_chroot($pidfile)) {
>         return &restart_bind();
>         }
> return undef;
> }
> 
> I think it should be
> 
> if (&check_pid_file(&make_chroot($pidfile))) {
> 
> because you open three '(' but only closing two ')'
> 
> I manually changed the code and after a test at my place everything works ok now.

Thanks for pointing that out .. I'll fix it for the next development
release.

 - Jamie