Re: [webmin-devel] [RFC] cosmetic change for edit_hdparm.cgi

[Jamie C. <jca...@we...>]

That's a good suggestion - I will include this patch in the next Webmin release.

 - Jamie

On 13/Oct/2007 03:38 Jean-Christophe Dubois wrote ..
> Hi,
> 
> When you are on the edit_hdparm form, there is no mention of the disk you are 
> dealing with. This is not so bad when you have only one disk and most of the 
> time you know for which disk you are editing the parameters=B5.
> 
> However if you have numerous disks, it doesn't hurt to remind the user which 
> disk it is playing with.
> 
> This is what this patch is doing.
> 
> JC
> 
> --- ./fdisk/edit_hdparm.cgi.org	2007-10-11 22:04:39.000000000 +0200
> +++ ./fdisk/edit_hdparm.cgi	2007-10-12 18:32:46.000000000 +0200
> @@ -33,7 +33,7 @@
>  print(
>  "<form action=3Dapply_hdparm.cgi><table border cols=3D1 width=3D\"100%\"><input 
> type=3Dhidden name=3Ddrive value=3D", $d -> { 'device' }, ">",
>      "<tr ", $tb, ">",
> -    	"<td><b>", $text{ 'hdparm_label' }, "</b></td>",
> +    	"<td><b>", $d -> { 'desc' }, " (", $d->{'device'},  "): ", 
> $text{ 'hdparm_label' }, "</b></td>",
>      "</tr><tr ", $cb, "><td>",
>  	"<table width=3D\"100%\">",
>  	    "<tr>",