Re: [webmin-devel] making config change to existing module, addingpopup"select users" list

[Mr D. <tl...@co...>]

Jamie Cameron wrote:
>>   return
>>       $preta .
>>       $config{'ignore_users'} .
>>       $postta .
>>       ' ' .
>>       &user_chooser_button("ignore_users", 1);
> I have one suggestion here - change the $config{'ignore_users'} to $_[0]

   OK.  I did so, and it works now. (= When I originally implemented
the function, I had it displaying all values to @_ to see if anything
was passed in, but since I didn't have a value yet, nothing was shown,
and I mistakenly assumed that nothing was passed in.  Slap my hand!
(=

   Anyway, it works now, and splendidly I must say.  AFAIK, these changes
satisfy your given requirements of "well written, don't break anything,
and optional".

   The only thing that I _don't_ have, however, is multi-language
config.info files. (=

   Is there anything else that you suggest I do/check/examine/etc
before I pass the patches and stuff on to you?

   Thanks!

Mr Duck