Re: [webmin-devel] webmin favicon weirdness

[Jamie C. <jca...@we...>]

On 4/Aug/2005 04:45 Colm Dougan wrote ..
> Hi list,
> 
> I am having a problem with favicons with webmin (1.020).
> 
> First the symptom : my favicon appears in the URL bar of Firefox but
> not beside the name when I have multiple tabs.  Hmm - how odd (I
> thought) it does it for all other favicons.
> 
> I should point out that I was putting my favicon.ico file in the base
> directory of the webserver (i.e. the same directory as
> session_login.cgi).  I'd like it to be there - its the default
> location for favicons and for silly reasons I won't go into I'd rather
> not use the <link rel=" ... workaround to reference it in another
> location.
> 
> Anyway - I think I've worked out why it happens.  When I first go to
> any page I get bounced to the login page.  I think at that stage
> Firefox is requesting /favicon.ico but that request will get a
> response telling it to login i.e. it seems that no document in "/"
> will work without a session other than session_login.cgi
> 
> So when I'm logged in subsequent requests to /favicon.ico will work
> properly (as long as I remember to add "image/x-icon ico"  to
> mime.types) but I think Firefox still has some memory of the initial
> request not suceeding due to lack of session and no amount of
> shift-reloading will convince it otherwise.  OK - so firefox is
> behaving a bit oddly but lots of people have it so I'd like to work
> around it.
> 
> I tried changing (hacking) miniserv.pl to add a special case for
> /favicon.ico (to serve it regardless of whether I have a session) and
> the problem went away which seemed to confirm my suspisions.
> 
> Anyway - any thoughts/advice on this?  Is there any easier way to make
> a special case for /favicon.ico to be served regardless of whether I
> have a session?  Would this still be an issue in later versions of
> webmin?  Am I just missing some much simpler solution?

This is really a bug in Webmin. It should serve that favicon.ico file
even to un-authenticated clients, just like it does already for .gif and .jpg
files in order to display images on the login page correctly.

I will fix this in the next release .. or you can fix it by changing line 3236
of miniserv.pl , to add .ico files to the unauthenticated regexp.

 - Jamie