Re: [webmin-devel] Virtualmin: Check_Config and Feature_Details

[Jamie C. <jca...@we...>]

Hi Paddy,

I finally got around to looking at your patch, and it looks good so far.
One small suggestion though - perhaps it might make sense to move the
code that works out what URL to redirect to into a function in the
appropriate feature-*.pl files? That way there could just be a single
.cgi that does the re-direction to whatever that function returns.
That's really a matter of taste though ..

Anyway, let me know when you think this patch is done, and I will be
glad to include it in the next Virtualmin release ..

 - Jamie

On Tue, 2004-12-07 at 12:02, paddy wrote:
> Jamie,
> 
> Sorry this has taken me a while to get around to.
> 
> Attached are two patches, but they are as yet rather rough.
> 
> They attempt to implement the following on edit_domain:
> 
> 	config option for 'check_config on page load'
> 	button for check_config
> 	features table is now 1x4, instead of 2x2
> 		col1: feature
> 		col2: enabled?
> 		col3: configured?
> 		col4: details (if -x details-$feature.cgi)
> 	individual check_$feature_config subs in each feature-$f.pl
> 	individual details-$feature.cgi redirects
> 
> The flaws are no doubt legion, but I feel I should highlight
> that _at least_ the following are still on my todo list:
> 
> 	lang support: 'ui text' -> $test{'ui_text'} as appropriate
> 	feature plugins
> 	webalizer (mine is broken ?)
> 	make details-dir redirect to file manager ? (get my java working)
> 
> My approach to 'configured?' is rough and ready.  I started with a 
> free-form text return rather than a specific coding, and I've yet to
> arrive at position on where such an interface should go.  At least once
> I've reached for a check_$feature_config routine for a reassuring binary
> 'yes we can do that', even though I generally believe in 'try it and
> return an error if necessary'.  Given the typical cost of a 
> check_$feature_config, more could be done both in terms of checking and
> in terms of feedback.  Also, I'm peripherally aware of html techniques that
> enable population of a slow rendering table after the rest of the page,
> but I'd need to look up the implementation, and I've no idea whether
> such a technique would fit in well with webmin. I would have put the 
> 'check' button at the top or bottom of the column, if I could easily
> have worked out how :)
> 
> With the 'details' links, I have chosen the easy route with individual 
> cgi's and treating the relationship between site and feature as essentially
> one-to-one (with the exception of mail which was already there, maybe I've
> overlooked others ?).  Nowhere is the latter hack more painfully obvious to 
> me than in details-logrotate.
> 
> Martin, I really have tried to avoid <td></td> and use <td>&nbsp;</td> :)
> 
> Anyway, enough waffle from me.
> 
> Please see attached code, feel free to tell me what you think!
> 
> Regards,
> Paddy