From: Jamie C. <jca...@we...> - 2004-06-07 00:11:32
|
On Sun, 2004-06-06 at 12:48, Jaldhar H. Vyas wrote: > Apologies for the late reply. I had to drop everything due to a heavy > work load. > > On Tue, 2 Jun 2004, Jamie Cameron wrote: > > > Having two root directories is neat, but may confuse some modules. A lot > > of them are written to assume that all module directories lie under the > > same root, and access files in other modules with paths like > > ../othermodule/somefile.pl . This could be fixed for the core modules, > > but may break third-party code .. > > > > Shouldn't they be using defined APIs like foreign_call etc? Then it would > just be a matter of patching those few functions in web-lib.pl Ideally, yes :-) However, not all do .. Fortunately, very few modules seem to be like this, so not many would be broken .. and certainly none of the core modules. > > I still think having one root directory is best, as long as there is no > > possibility of modules from .deb packages being overwritten, > > and vice-versa... Yes.. I presume you only create .deb packages for the standard modules, and not for any third-party modules? > > which seems > > to be the core problem here. > > > > Also what about cloned modules? Currently rpm and dpkg can't deal with > those at all. That's a whole other problem :-( The current method via which cloning is done is not optimal, as clones are not stored in /etc/webmin as they should be. Perhaps introducing support for multiple root directories could help solve this too, but creating clones as links under some /etc/webmin/clones directory, rather than links in /usr/libexec/webmin .. - Jamie |