[webmin-devel] config.info files not allowing commas

[John H. <j....@pl...>]

Hello,

I was modifying a modules config.info file and purely for grammatical
reasons entered a comma into the text of the config option:

    show_list=Display zones, views and records as,1,0-Icons,1-List

Webmin (1.110) didn't like this and showed the text up to the comma and
then made a mess of the radio buttons that should have appeared.

As far as I can see config-lib.pl at lines 23/24 uses split to seperate
the various parts of the config line:

       local @p = split(/,/, $info{$c});
       local @ep = split(/,/, $einfo{$c});


I was wondering if this could be changed to not split on escaped commas,
along the lines of:

        local @p = split(/(?<!\\),/, $info{$c});
        local @ep = split(/(?<!\\),/, $einfo{$c});
        $p[0] =~ s/\\,/,/go;
        $ep[0] =~ s/\\,/,/go;

I have tried this and it seems to work okay. I have no idea though if
there are any unseen knock-on effects further on in the code.




Regards,

John.

-- 
---------------------------------------------------------------
John Horne, University of Plymouth, UK  Tel: +44 (0)1752 233914
E-mail: Joh...@pl...       Fax: +44 (0)1752 233839