[webmin-devel] [patch] quota v2 - vsfv0 not supported before 2.4.19 kernels

[Christophe C. <chr...@pu...>]

Hi,

[ Hope it's the good list to post.. ]

quotaon() in the quota module dont always work for kernels <= 2.4.18
It fails (on some Linux) with an error msg like this

# quotaon -u /home/
quotaon: Cannot find quota file on /home [/dev/hda7] to turn quotas on/off.

Reason is the module tries to use quota v2 (vfsv0, aquota.user),
after converting from quota v1 quota.user (convertquota)
But there is no vfsv0 support in official kernels < 2.4.19
unless patched (RedHat >= 7.1 or Suse >= 7.2).
See quotadoc.sgml in cvs of linuxquota (sourceforge)
and ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4

# uname -r
2.4.18-bf2.4

# quotaon -F vfsv0 -u /home/
quotaon: Required format vfsv0 not supported by kernel.

I'm using Debian GNU/Linux 3.0 with std kernel 2.4.18.

I've made a patch that uses std quota.user instead of aquota.user
for kernels < 2.4.19. Perhaps its not the better way, but at least
it works, and should be harmless for later kernels.
I also replace the quota version check from v2 to v3, as I think
vfsv0 support wasnt there before quotatools v3.
Finally, I made '$_[0]' the argument of convertquota instead of
'/', which I guess was a typo.

The patch if for quota/debian-linux-lib.pl (from webmin 1.121)
but the same changes should be applied for quota/linux-lib.pl
Feel free to use/modify it (I added too verbose comments),
or resolve that issue a better way.

Regards,

Christophe