|
From: Jamie C. <jca...@we...> - 2014-09-27 16:38:31
|
On 27/Sep/2014 08:26 dl <dl....@nt...> wrote .. > If I wish to add extra frame(s) to the existing UI frameset (e.g. in > gray-theme/index.cgi and other such themes) for a module under development. > > I find from initial UI experiments that I may have to search through the > entire Webmin directory to change .. > > frames[0] .. to frames['left'] > frames[1] .. to frames['right'] > > Is this finding correct? > > Otherwise the rendered frames do not map correctly to src links. > > The intended frame 'topbar' is planned to provide a Webmin workflow for > usage of Webmin functions in batch modes. Adding a top bar sounds cool (and indeed some really old themes did this), but I don't see why it would require changing code outside of the theme directory itself. What other files did you have to change? > While on the subject why not in some later release switch to div > containers throughout instead of using framesets? A couple of themes that work this way are under development, but it is tricky because all the module code assumes that URLs are relative to the module sub-directory. Which isn't the case if a div is being used. |