Re: [webmin-devel] SpamAssassin Module - Webmin 1.119 - Custom Rule regex problem - spamd restart

[Jamie C. <jca...@we...>]

On Wed, 2003-10-29 at 17:45, Larry Gilson wrote:
> Hi Jamie,
> 
> 
> I was testing the "Header and Body Tests".  I noticed a problem saving a
> regex.  I have the following rule:
> 
>     Received =~ /from.* \(unknown \[\d+\.\d+\.\d+\.\d+\]\)/i
> 
> When saving, I received the following error:
> 
> #-----
> Failed to save tests : '/from.* \(unknown \[\d+\.\d+\.\d+\.\d+\]\)/i' is not
> a valid regular expression (must be like /expression/)
> #-----
> 
> Now when I manually enter the rule in the local.cf and review the rule in
> the module, it looks like:
> 
>     Regular Expression       Default Value
>     /from.*                  \(unknown
> 
> My guess is that the escapes are causing a problem.

Actually, it's the spaces in the regexp. I will fix this for the 1.120
release .. thanks!

> Additionally, it appears that you are only checking for the presence of
> spamc in a procmail recipe.  Is that true?  If spamc/spamd is utilized,
> spamd must be restarted or reloaded (2.60) to load the new rules into
> memory.  This would mean that administrators have the ability to create and
> modify the rules through this module but would not have the ability to
> implement them if running spamc/spamd.  SA 2.55 and earlier needs to have
> spamd restarted and 2.60 can either be restarted or it can reload it's
> configuratio via SIGHUP.  A pid file may exist only if spamd is invoked with
> the '-r' switch.  The spamd doc lists a note that:
> 
> "If spamd receives a SIGHUP, it internally reloads itself, which means that
> it will change its pid and might not restart at all if its environment
> changed (ie. if it can't change back into its own directory). If you plan to
> use SIGHUP, you should always start spamd with the -r switch to know its
> current pid."
> 
> I would think that the best option is to restart if spamd was not invoked
> with the '-r' switch.

Fortunately, Joe Cooper already pointed this one out to me, and so the
final module will have a button for sending a HUP signal to the running
spamd process (if there is one).

 - Jamie