RE: [webmin-devel] FileManager problem

[Keisuke M. <Kei...@Ph...>]

Jamie,=20

I understand your point about compatibility, but let me make sure one
thing.
AFAIK, JDK 1.1 does support *Reader classes. Do you mean JDK 1.0?

If so, adding the charsets decoding support to LineInputStream would be
quite a lot of work (because it is just re-implementing *Reader
classes),=20
so I prefer to implement as follows:

 - implement our own wrapper Reader class.
 - the wrapper class tries to load and instantiate *Reader classes and
works as my
   previous patch does if it's succeeded.
 - if it's failed with throwing either NoClassFound or
UnsupportedEncoding exception,=20
   the wrapper uses LineInputStream class instead. In this case, some
international=20
   languages won't be displayed correctly and we live with  this as
"spec" in JDK 1.0 browser.

I'm going to modify the code so if it's all right.

By the way, do you know any versions of browser that runs JDK 1.0
applets and=20
can be obtained today? I tried but I couldn't find any ones around me
so...

Thank you.
--=20
Keisuke MORI


> -----Original Message-----
> From: Jamie Cameron [mailto:jca...@we...]=20
> Sent: Wednesday, August 20, 2003 11:26 PM
> To: web...@li...
> Subject: Re: [webmin-devel] FileManager problem
>=20
>=20
> That's a very useful patch, as supporting non-european=20
> characters in the
> file manager Java applet has always stumped me (due to Java's use of
> Unicode vs. various other encodings for the rest of webmin). However,
> there is one problems with your patch - it makes use of some *Reader
> classes that are not available in Java 1.1, and I want to=20
> make sure the
> applet remains compatible with that version of Java due to the large
> number of web browsers out there with support only for that old
> version..
>=20
> Any chance you could modify it to make use of LineInputStream again?
>=20
>  - Jamie
>=20
> On Tue, 2003-08-19 at 16:09, Keisuke Mori wrote:
> > Hi,
> >=20
> > FileManager seems to have a problem on displaying=20
> > international language texts on icons and buttons of the=20
> > Java Applet.  Garbage strings are displayed on the icons when
> > language setting is changed to other than English. (e.g.=20
> Japanese in my
> > case)
> >=20
> > I'm sending a patch as my suggestion of fixing this problem.
> > This patch fixes as follows:
> >   - lang.cgi returns the current charset in Content-type: header.
> >   - FileManager.get_text() retrieves the charset and decode=20
> >     the icon texts accordingly.
> >   - LineInputStream class is no longer needed.
> >   - corrects one Japanese translation error
> >=20
> > I hope it helps.
> > Thank you.
> > --=20
> > Keisuke MORI
> > Phoenix Technologies K.K.
>=20
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.net email is sponsored by Dice.com.
> Did you know that Dice has over 25,000 tech jobs available today? From
> careers in IT to Engineering to Tech Sales, Dice has tech=20
> jobs from the
> best hiring companies. http://www.dice.com/index.epl?rel_code=3D104
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
>=20