|
From: Michael A. P. <mp...@ma...> - 2001-10-02 17:00:11
|
I have a few patches I'd like to submit. Webmin fails to properly start at system boot on OS X 10.1 The problem is that apple appends an "exit 0" at the end of the rc script. Thus, along comes webmin, and puts its startup line after the exit 0 I'm sure you can see the problem... Anyway, what I did was patch webmin to instead of using /etc/rc to launch itself, it now created the necessary stuff in /Library/StartupItems and adds an entry into /etc/hostconfig. This is actually the "kosher" way to do it on Darwin based systems anyway, so rather than try and hack the atboot.pl to insert the startup request before the exit 0, I hacked it do things the Apple way. I also patched the delboot.pl to clean up after itself. These two patches (to webmin-0.88) can be viewed here: http://24.5.29.77:10080/WEBMIN_MAC/atboot.patch http://24.5.29.77:10080/WEBMIN_MAC/delboot.patch In order for the patches to work, the /init/config-macos file needs to be modified. This is what mine looks like: reboot_command=reboot shutdown_command=halt darwin_setup=/Library/StartupItems hostconfig=/private/etc/hostconfig status_check=0 -=- OK- with just those changes, webmin will install on OS X and start at boot. Those two patches and the change to the config file are the things I'm most interested in seeing work their way into the webmin standard source. However, I also made another rather radical change, but I think its one that is for the better, one I would like to suggest. I changed every filename that contains macos to instead contain darwin. Thus, config-macos becomes config-darwin. And, of course, a sed script changed all the references from macos to darwin within the files themselves :) I also modified the os_list.txt file to better add support for the various flavors of Darwin out there. The new os_list.txt file can be viewed at http://24.5.29.77:10080/WEBMIN_MAC/os_list.txt Darwin is the unix core of OS X, and Darwin is available for free for both the PowerPC and the x86 platform. Both Mac OS X and Mac OS X Server are based upon, but different than Darwin. They both are Darwin underneath, but are different OS's sold for different purposes. That is why I personally thought it better for the config files to be called config-darwin opposed to config-macos. Webmin is about unix, and Darwin in the unix part of Mac OS X and Mac OS X Server. If that change seems to major, I understand- but the updated os_lists.txt should be considered even if the changes from config-macos to config-darwin seem too major. I have a webmin-0.88 tarball that contains my patches already applied. I have tested it on several OS X/Darwin installs, and tested it on a Linux install to make sure I didn't break anything there. I did not have an opportunity to test it on a system where an rc script is the proper place. The updated tarball (and everything, in fact) is at http://24.5.29.77:10080/WEBMIN_MAC/ directory listing is turned on. Any comments or suggestions? http://24.5.29.77:10080/OSX-Darwin/ |