Re: [webmin-devel] MySQL module - multi line editor field sizes

[Jamie C. <jca...@we...>]

On 25/Aug/2008 16:33 Andreas Kilgus wrote ..
> Hello,
> 
> IMHO the way the multi line editor decides which kind of html form element
> to use for specific fields is problematic. A field of type "text" is
> represented by the means of a textarea while "varchar(4000)" gets a one
> line input field (though the maximal size of 4000 chars is an indicator
> that multi line text might be expected as value).
> 
> Is there any reason I don't take into consideration at the moment not to
> change "libexec/webmin/mysql/view_table.cgi" starting at line 300 into
> something like 
> 
> elsif ($str[$j]->{'type'} =~ /\((\d+)\)/) {
>     # Show as known-size text
>     if ($1 < 256) {
>         local $nw = $1 > 70 ? 70 : $1;
>         $et .= &ui_textbox($nm, $d[$j], $nw);
>     } else {
>         $et .= &ui_textarea($nm, $d[$j], 3, 70);
>     }
> }
> 
> ?

That's a good suggestion - I will include this in the next Webmin release.
The only reason for the current code is that when I wrote it, large varchars
weren't supported in MySQL.

 - Jamie