Re: [webmin-devel] Possible bug

[Jamie C. <jca...@we...>]

On 28/Feb/2008 16:33 John Gray wrote ..
> Jamie Cameron wrote:
> > On 28/Feb/2008 14:15 Bill Moyers wrote ..
> >   
> >> I think there may be a bug in Virtualmin 3.53 (GPL). We have 3.46 (GPL)
> >> running on one box and it correctly reports domain user counts on
> >> virtual-server/index.cgi. The 3.53 installation reports much lower
> >> numbers.  Checking out the code, it looks like the new version calls
> >> &count_domain_users() to get the counts whereas the old version uses the
> >> length of &list_domain_users(domain). I'm not 100% sure what causes the
> >> erroneous results, but it looks like &count_domain_users expects the home
> >> directories to be in a predetermined structure which ours I think don't
> >> match. Any thoughts? For now I've changed it use the old method for
> >> counting users.
> >>     
> >
> > Hi Bill,
> >
> > The 3.53 version of Virtualmin changed the way users were counted, as
> > the old method was rather slow - it involved a call to list_domain_users
> > for each domain, which collected a lot more information than was needed.
> >
> > But it is a bug if they don't return the same counts. What kind of directory
> > structure are you using for your users there?
> >
> >   
> Before we started using virtualmin,  the structure for the home 
> directories was /home/<username>
> 
> It looks like its not counting those users.

Ok, that would explain it - if the mailbox's home directory is not under the
domain's home, it will not be counted. I will fix this in the next Virtualmin
release, by falling back to using the GID for determining the domain.

 - Jamie