Re: [webmin-l] Bug in Filesystem Quotas Module?

[Jamie C. <jca...@we...>]

On 30/Jul/2006 18:38 Murray Trainer wrote ..
> On Sat, 2006-07-29 at 11:54 -0700, Jamie Cameron wrote:
> > On 25/Jul/2006 23:42 Murray Trainer wrote ..
> > > On Tue, 2006-07-25 at 09:49 -0700, Jamie Cameron wrote:
> > > > On 25/Jul/2006 01:50 Murray Trainer wrote ..
> > > > > Hi Jamie,
> > > > > 
> > > > > When I add a user with a totally numeric userid like 12345678 the
> quotas
> > > > > appear normal via repquota -s /home but when I look in the Filesystem
> > > > > Quotas module I get two entries for the user, ie 12345678 and #12345678.
> > > > > The first one displays the correct disk usage and the second shows
> > > > > none.  
> > > > 
> > > > Adding users with names like that is a bad idea, as the quota commands
> > > will
> > > > get confused between UIDs and usernames. For example, if you run
> :
> > > > 
> > > > edquota -t 12345678
> > > > 
> > > > it may set the quotas for the user named 12345678, or with UID 12345678.
> > > > Because Webmin just calls thse commands, it cannot handle this situation
> > > > as you'd expect.
> > > 
> > > Edquota should probably be fixed but as a workaround could you run
> > > edquota with the numeric id of the user as the argument instead of
> the
> > > name to avoid this problem?
> > 
> > That won't work though ..
> > I checked into this further, and found that if you run edquota with a
> numeric username, it will always assume this this is a UID, even if no user with
> that ID exists.
> > 
> >  - Jamie
> 
> Exactly, not sure if you got my point though.  I meant that if edquota
> always assumes numeric usernames are UID numbers then if you run edquota
> with the UID number it would always behave as expected.  Doesn't matter
> for now as we have stopped fully numeric userid's from being created
> anyway.  It would probably be a pain for you to change this and
> potentially break the module on some types of systems.  Personally I
> think edquota should be fixed - I noticed that HP have already done that
> on their version of Unix.

Doh! You are absolutely correct .. I was somehow thinking that edquota
was working the other way around. I will update Webmin in the next release
to always use UIDs, which will solve this problem.

 - Jamie