Ivica Glavocic - 2014-05-16

HI all

Webmin Shorewall module assumes that last line in configuration files ends with #
because old Shorewall config files had last line:

#LAST LINE -- ADD YOUR ENTRIES BEFORE THIS ONE -- DO NOT REMOVE

In new Shorewall versions that line is removed and parameters are supposed to be added on bottom of the file, not before last hash. As Webmin still adds entries before #, Shorewall configuration now looks like this (/etc/shorewall/zones):

INT     ipv4                            # Internet
LAN     ipv4                            # Local network
#
# Shorewall version 4 - Zones File
#
# For information about this file, type "man shorewall-zones"
#
# The manpage is also online at
# http://www.shorewall.net/manpages/shorewall-zones.html
#
###############################################################################
#ZONE   TYPE            OPTIONS         IN                      OUT
#                                       OPTIONS                 OPTIONS
fw      firewall

INT and LAN ade added by Webmin on top, while fw is default and on bottom.
Webmin should add it's entries also on bottom, AFTER fw.
Please correct that in new version of Shorewall.

Thanks, regards

Ivica