Menu

#4336 dhcp *zones.cgi scripts not checking acl

1.660
closed-fixed
nobody
None
5
2013-12-24
2013-12-23
No

I noticed I wasn't able to edit zones in the dhcp module. I think we are just missing the get_module_acl call from the *_zones.cgi scripts.

I added the >> line to edit_zones.cgi and save_zones_cgi
require './dhcpd-lib.pl';
require './params-lib.pl';
&ReadParse();

%access = &get_module_acl();
$access{'zones'} || &error($text{'zone_ecannot'});

I did this to my edit_zones.cgi and save_zones.cgi and all seems well, Hopefully you have a bug and fix :)

Discussion

  • Jamie Cameron

    Jamie Cameron - 2013-12-24

    Thanks for reporting this. I was just about to check in a fix when I noticed that another contributor to Webmin had already fixed it with this commit : https://github.com/webmin/webmin/commit/1a7dc5842ca06c325f06abb7f276a6621df1b1b8

    This fix will be in the next Webmin release.

     
  • Jamie Cameron

    Jamie Cameron - 2013-12-24
    • status: open --> closed-fixed
     

Log in to post a comment.