Re: [Web-meetme-devel] testing

[Dan A. <Dan...@Ph...>]

=20
Dan Austin wrote:
>  Don't sweet it.  I've been coding like a mad man, as a recent
> upgrade here finally killed the proprietary conferencing platform
> we were using.  That basically forced management to let me deploy
> Asterisk and Web-MeetMe.  The response internally has been excellent,
> and goaded me into adding a number of planned features.
>=20
> I've found a couple of issues that involve your code that I could
> not determine the best way to proceed.
>=20
> 1.  _SESSION['userid'] vs _SESSION['username']
> 	You have both, but the code seems to prefer userid, except
> 	for displaying the conference owner.  The easiest fix would
> 	be for LDAP authentication to set both, but I'm not clear on
> 	why both are needed.

> This is probably bad coding on my part. I can review the latest code
to=20
> make it consistent and eliminate the unneeded one (probably
'username'.=20
> This is related to me eliminating the need for a text username and=20
> simply using email addresses for login.
I started to convert the LDAP code to userid, but stopped when I saw you
had both.  There is only a couple of instances left in the svn tree.

> 2.  The direct MySQL queries.=20
> 	I really like the functionality you added using them, and=20
> 	I've done the same in a couple of new features, but this breaks
> 	the database agnostic approach, and likely ends support for
> 	postgres.  While I don't use postgres, I think we should try
> 	to maintain the flexibility.

> I thought I used the PEAR DB libraries which support MySQL, PostgreSQL

> and several othe DBs.I find those routines much easier to read and=20
> understand than what was being used. Another option is ADODB. I have=20
> never used that abstarction library, but understand it is more
efficient=20
> than the PEAR routines. It does support all the major RDBMSes.
>=20
You may have.  I did not notice any new libraries, and was not really=20
focused on them, so I might have missed them.

> Oh, and I just added a redirect on my home server to point people
> looking for the package to SF and saw the stats jump quite a bit.
>=20
Thanks,

Mike


_______________________________________________
Web-meetme-devel mailing list
Web...@li...
https://lists.sourceforge.net/lists/listinfo/web-meetme-devel