web-erp-developers

Re: [WebERP-developers] Unable to invoice customers

[rfthomas <rf...@as...>]

Raphael,

There are no includes in DefineCartClass.php.  The header on the file is:



I double checked the V4.11.5 .zip distribution and such is in that version.

Bob Thomas



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Unable-to-invoice-customers-tp4657770p4657772.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

Re: [WebERP-developers] Unable to invoice customers

[rfthomas <rf...@as...>]

The distribution was downloaded on 10/14/2014.  According to SourceForge it
was created on 10/13/2014.

The number of changed scripts from 4.11.3 to 4.11.5 break down as follows:

There are 35 new scripts
262 modified scripts - over 50% of the scripts have been modified.  The
changes range from trivial (formatting text for legibility) to total
rewrites.

Bob Thomas



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Unable-to-invoice-customers-tp4657770p4657773.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

Re: [WebERP-developers] Unable to invoice customers

[Rafael C. <raf...@gm...>]

Hi Bob,

Sorry for my English. I want to say: if you have a file
"DatabaseTranslations.php" in the folder /includes.

The purpose of the file "DatabaseTranslations.php" is to translate
"Freight" when it is shown in the display, instead of translate this tax
category inside the database. When you include this file
(DatabaseTranslations.php),
you should delete the translation in the other scripts.

Inside includes/DefineCartClass.php in line 372:

* With file "DatabaseTranslations.php" (tax category is in en-GB):
$sql = "SELECT taxcatid FROM taxcategories WHERE taxcatname='Freight'";//
This tax category is hardcoded inside the database.

* Without  file "DatabaseTranslations.php"
(Tax category is translated inside the database):
$sql = "SELECT taxcatid FROM taxcategories WHERE taxcatname='" .
_('Freight') . "'";// This tax category is hardcoded inside the database.

Best regards, Rafael


2014-10-27 16:30 GMT-06:00 rfthomas <rf...@as...>:

> Raphael,
>
> There are no includes in DefineCartClass.php.  The header on the file is:
>
>
>
> I double checked the V4.11.5 .zip distribution and such is in that version.
>
> Bob Thomas
>
>
>
> --
> View this message in context:
> http://weberp-accounting.1478800.n4.nabble.com/Unable-to-invoice-customers-tp4657770p4657772.html
> Sent from the web-ERP-developers mailing list archive at Nabble.com.
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>

Re: [WebERP-developers] Unable to invoice customers

[Phil D. <ph...@lo...>]

So bob actually needs a "Shipping" tax category now and can lose the freight one
Regards
Phil
Phil Daintree
Cell: +64 (0) 275 567890
http://www.logicworks.co.nz

On 28 October 2014 12:01:46 PM NZDT, "Rafael Chacón" <raf...@gm...> wrote:
>Hi Bob,
>
>Sorry for my English. I want to say: if you have a file
>"DatabaseTranslations.php" in the folder /includes.
>
>The purpose of the file "DatabaseTranslations.php" is to translate
>"Freight" when it is shown in the display, instead of translate this
>tax
>category inside the database. When you include this file
>(DatabaseTranslations.php),
>you should delete the translation in the other scripts.
>
>Inside includes/DefineCartClass.php in line 372:
>
>* With file "DatabaseTranslations.php" (tax category is in en-GB):
>$sql = "SELECT taxcatid FROM taxcategories WHERE
>taxcatname='Freight'";//
>This tax category is hardcoded inside the database.
>
>* Without  file "DatabaseTranslations.php"
>(Tax category is translated inside the database):
>$sql = "SELECT taxcatid FROM taxcategories WHERE taxcatname='" .
>_('Freight') . "'";// This tax category is hardcoded inside the
>database.
>
>Best regards, Rafael
>
>
>2014-10-27 16:30 GMT-06:00 rfthomas <rf...@as...>:
>
>> Raphael,
>>
>> There are no includes in DefineCartClass.php.  The header on the file
>is:
>>
>>
>>
>> I double checked the V4.11.5 .zip distribution and such is in that
>version.
>>
>> Bob Thomas
>>
>>
>>
>> --
>> View this message in context:
>>
>http://weberp-accounting.1478800.n4.nabble.com/Unable-to-invoice-customers-tp4657770p4657772.html
>> Sent from the web-ERP-developers mailing list archive at Nabble.com.
>>
>>
>>
>------------------------------------------------------------------------------
>> _______________________________________________
>> Web-erp-developers mailing list
>> Web...@li...
>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>
>
>
>------------------------------------------------------------------------
>
>------------------------------------------------------------------------------
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Web-erp-developers mailing list
>Web...@li...
>https://lists.sourceforge.net/lists/listinfo/web-erp-developers

Re: [WebERP-developers] Unable to invoice customers

[rfthomas <rf...@as...>]

Freight is hard coded in the scripts.  The small change works and "Freight"
is translated into "Shipping" in the displays.  In any case Freight is a
common term in the US.

The small change just needs to be made in DefineCartClass.php and no
database changes were needed.

Bob Thomas




--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Unable-to-invoice-customers-tp4657770p4657776.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

Re: [WebERP-developers] Unable to invoice customers

[Phil D. <ph...@lo...>]

Yes - it is not quite clear on the best approach. It really is not nice 
to rely on this hard coded FREIGHT and now to translate FREIGHT and rely 
on the translated _('FREIGHT') existing in the database. Maybe the 
better approach is to have a config option that defines the tax category 
that freight should belong to.

Phil

Phil Daintree
Logic Works Ltd - +64 (0)275 567890
http://www.logicworks.co.nz

On 28/10/14 14:37, rfthomas wrote:
> Freight is hard coded in the scripts.  The small change works and "Freight"
> is translated into "Shipping" in the displays.  In any case Freight is a
> common term in the US.
>
> The small change just needs to be made in DefineCartClass.php and no
> database changes were needed.
>
> Bob Thomas
>
>
>
>
> --
> View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Unable-to-invoice-customers-tp4657770p4657776.html
> Sent from the web-ERP-developers mailing list archive at Nabble.com.
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>