Thread: [WebERP-developers] Inconsistency in Customer - branch codes

Accounting & Best Practice Business Administration System

Brought to you by: daintree, exsonqu, rchacon, tim_schofield, turbopt

web-erp-developers

[WebERP-developers] Inconsistency in Customer - branch codes

From: Pak R. <pak...@gm...> - 2014-01-23 03:20:28

Hi:

I just set up a new customer coded JOHN-USD (all ok).
When trying to save the first branch, webEERP proposes the code "JOHN-USD",
which is a great idea to have the same code
But when trying to save it, it is rejected because contains an special
symbol - & \' < >

I think it should have the same checks on both sides (customer code and
branch code). Personally I see no problem using - & < > chars for codes,

Regards,
Ricard

Re: [WebERP-developers] Inconsistency in Customer - branch codes

From: Pak R. <pak...@gm...> - 2014-01-23 03:26:31

Oppps! I forgot:

Besides the previous issue, webERP allows to delete the customer branch
when there's only 1 branch, and later on there is no way to:

Add another branch to the customer.
Select the customer without branches

So, we left a row in debtorsmaster that can't be used. I guess deleting the
last customer branch should not be allowed or deleting the last customer
branch should start the deletion of the debtorsmaster row as well.

Regards,
Ricard


2014/1/23 Pak Ricard <pak...@gm...>

> Hi:
>
> I just set up a new customer coded JOHN-USD (all ok).
> When trying to save the first branch, webEERP proposes the code
> "JOHN-USD", which is a great idea to have the same code
> But when trying to save it, it is rejected because contains an special
> symbol - & \' < >
>
> I think it should have the same checks on both sides (customer code and
> branch code). Personally I see no problem using - & < > chars for codes,
>
> Regards,
> Ricard
>

Re: [WebERP-developers] Inconsistency in Customer - branch codes

From: ExsonQu <hex...@gm...> - 2014-01-23 05:05:51

*Hi, Richard,*

           Thank you for your report!

           The validation pattern in client side is just try to keep
consistent with server side validation.  If you've passed the client side
validation. The server side still will catch the illegal chars. 

            So the question is that shall we add this validation to
Customers.php script to keep the consistency with CustomerBranches.php ?

            Thanks and best regards!

            Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Inconsistency-in-Customer-branch-codes-tp4657184p4657186.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

Re: [WebERP-developers] Inconsistency in Customer - branch codes

From: Pak R. <pak...@gm...> - 2014-01-23 05:15:34

Hi Exson:

I think we should allow the use of these chars. Why can't a branch code
have the - sign? We can use it for stockid, so why not for customer
branches?

Regards,
Ricard


2014/1/23 ExsonQu <hex...@gm...>

> *Hi, Richard,*
>
>            Thank you for your report!
>
>            The validation pattern in client side is just try to keep
> consistent with server side validation.  If you've passed the client side
> validation. The server side still will catch the illegal chars.
>
>             So the question is that shall we add this validation to
> Customers.php script to keep the consistency with CustomerBranches.php ?
>
>             Thanks and best regards!
>
>             Exson
>
>
>
> --
> View this message in context:
> http://weberp-accounting.1478800.n4.nabble.com/Inconsistency-in-Customer-branch-codes-tp4657184p4657186.html
> Sent from the web-ERP-developers mailing list archive at Nabble.com.
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>

Re: [WebERP-developers] Inconsistency in Customer - branch codes

From: gilberto d. s. a. <gs...@gm...> - 2014-01-24 02:44:28

IMO is that customer, customer branch and vendors must have same
validation, alfanumeric and hifen char (-) and undercore char (_). this
help all of us for url (get and post) and urlencode/urldecode. many
functions on php, python, xml and api already have these constraints.
reference [1] et ali.
See http get processing, example:
http://weberp.brasil.com.br/Customers.php?customercode=xxxxxxxxx
If in this hypotetical case code xxxxxxxxx have some special char we must
use aditional urlencode/urldecode for http server handle it.

regards!
[1] http://us3.php.net/manual/en/function.urlencode.php<http://us3.php.net/manual/pt_BR/function.urlencode.php>


2014/1/23 ExsonQu <hex...@gm...>

> *Hi, Richard,*
>
>            Thank you for your report!
>
>            The validation pattern in client side is just try to keep
> consistent with server side validation.  If you've passed the client side
> validation. The server side still will catch the illegal chars.
>
>             So the question is that shall we add this validation to
> Customers.php script to keep the consistency with CustomerBranches.php ?
>
>             Thanks and best regards!
>
>             Exson
>
>
>
> --
> View this message in context:
> http://weberp-accounting.1478800.n4.nabble.com/Inconsistency-in-Customer-branch-codes-tp4657184p4657186.html
> Sent from the web-ERP-developers mailing list archive at Nabble.com.
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>



-- 
gilberto dos santos alves
+55.11.98646-5049
sao paulo - sp - brasil

Re: [WebERP-developers] Inconsistency in Customer - branch codes

From: Phil D. <ph...@lo...> - 2014-01-24 09:25:07

ContainsIllegalCharacters function now allows - and _ characters - but 
the hyphen was trapped separately - now fixed thanks for the report Ricard.
I have also disallowed deletion of the last branch as suggested and made 
the delete customer option delete any branches left provided there are 
no dependent records.

Thanks

Phil

Phil Daintree
Logic Works Ltd - +64 (0)275 567890
http://www.logicworks.co.nz

On 23/01/14 16:19, Pak Ricard wrote:
> Hi:
>
> I just set up a new customer coded JOHN-USD (all ok).
> When trying to save the first branch, webEERP proposes the code 
> "JOHN-USD", which is a great idea to have the same code
> But when trying to save it, it is rejected because contains an special 
> symbol - & \' < >
>
> I think it should have the same checks on both sides (customer code 
> and branch code). Personally I see no problem using - & < > chars for 
> codes,
>
> Regards,
> Ricard
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers