From: Debi C. <deb...@ya...> - 2011-11-21 15:44:12
|
---------------------------------------------------------------------- Problem: ---------------------------------------------------------------------- We sell industrial hoses and fittings with an inventory of over 9,000 parts. We need to search for items without having to know the exact order keywords might show up in the description.For example, the inventory search SS HEX SCREW would not return results for an item with the description 5/16 HEX SL PS SCREW 9/16 SS BA HSG ---------------------------------------------------------------------- Solution: ---------------------------------------------------------------------- Change all inventory description search scripts so that order of keywords doesn't matter by changing the query from "LIKE %SS%HEX%SCREW%" to "LIKE %SS% AND LIKE %HEX% AND LIKE %SCREW%" ---------------------------------------------------------------------- Scripts to be changed: ---------------------------------------------------------------------- BOMInquiry.php BOMs.php ContractBOM.php CounterSales.php MRPDemands.php MRPReport.php PO_Items.php PO_SelectOSPurchOrder.php PO_SelectPurchOrder.php SelectCompletedOrder.php SelectCreditItems.php SelectOrderItems.php SelectProduct.php SelectSalesOrder.php SelectWorkOrder.php Shipt_Select.php SupplierTenders.php WorkOrderEntry.php WorkOrderIssue.php ---------------------------------------------------------------------- Script modification: ---------------------------------------------------------------------- CHANGE where the script builds the search string. (Take care to locate the line that is building the inventory search string, not another type of search string, like customer name.) $SearchString = '%' . str_replace(' ', '%', $_POST['Keywords']) . '%'; TO building the new SQL search phrase instead $SearchWords = explode(" ", $_POST['Keywords']); $SearchWordsCount = substr_count($_POST['Keywords'], ' '); $SearchStringPhrase = ""; for ($i = 0; $i <= $SearchWordsCount; $i++) { $SearchStringPhrase .= " AND stockmaster.description LIKE '%" . $SearchWords[$i] . "%'"; } CHANGE where the script builds the SQL statement (sometimes there are multiple instances of this line) AND stockmaster.description " . LIKE . " '$SearchString' TO the SQL search phrase " . $SearchStringPhrase . " OR sometimes the line might be WHERE stockmaster.description " . LIKE . " '$SearchString' in that case, change it to WHERE 1 " . $SearchStringPhrase . " I hope this change will be considered for incorporating into the next release. The ability to do a literal search might be a nice addition, too. Debi Odessa, Texas, USA |
From: opto <bu...@op...> - 2011-11-21 17:26:51
|
if adopted, it might be nice to set this in configuration or elsewhere, as one might not always want such a search behaviour. Klaus -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4092305.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: DebiCates <deb...@ya...> - 2011-11-22 01:39:31
|
Klaus, now that you mention it, I can envision the possible unexpected headache this change might cause for current users. It would be best included as an option. For example, two parts with descriptions 5/16 HEX SL PS SCREW 9/16 SS BAND 9/16 HEX SL PS SCREW 3/32 SS BAND Under the current search query, the user could rely that entering 9/16 SCREW will find only the second item. With my change, of course it finds both. For us, the limitation of keyword order (often netting NO results) was more frustrating than too many. I figured there might be others with the same issue. It would be nice to devise a solution that would accommodate both types of search. Perhaps entering *9/16 SCREW* could signify an in-order search like it works now. A literal search signifier would be undoubtedly expected then, too. And a NOT signifier too. Then allowing the user to mix them up in one search would be an interesting challenge. Like, *9/16 SCREW* "SS BAND" #SL# PS And it would be even better to use a table to dictate the characters used for each type of search signifier. Oh, and lastly to include instructions in the manual! ;) This is something I might commit to do. Any other thoughts out there? -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4094151.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: Phil D. <ph...@lo...> - 2011-11-22 05:13:02
|
I'm not picking up on why this would be bad for you Klaus? Using Debi's logic you would still get the same items returned and possibly some more. I am thinking this makes sense as a change. What am I missing Klaus? Phil Phil Daintree Logic Works Ltd - +64 (0)275 567890 http://www.logicworks.co.nz On 22/11/11 14:39, DebiCates wrote: > Klaus, now that you mention it, I can envision the possible unexpected > headache this change might cause for current users. It would be best > included as an option. > > For example, two parts with descriptions > 5/16 HEX SL PS SCREW 9/16 SS BAND > 9/16 HEX SL PS SCREW 3/32 SS BAND > > Under the current search query, the user could rely that entering 9/16 SCREW > will find only the second item. With my change, of course it finds both. For > us, the limitation of keyword order (often netting NO results) was more > frustrating than too many. I figured there might be others with the same > issue. > > It would be nice to devise a solution that would accommodate both types of > search. Perhaps entering *9/16 SCREW* could signify an in-order search like > it works now. A literal search signifier would be undoubtedly expected then, > too. And a NOT signifier too. Then allowing the user to mix them up in one > search would be an interesting challenge. Like, > > *9/16 SCREW* "SS BAND" #SL# PS > > And it would be even better to use a table to dictate the characters used > for each type of search signifier. Oh, and lastly to include instructions in > the manual! ;) > > This is something I might commit to do. Any other thoughts out there? > > > > -- > View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4094151.html > Sent from the web-ERP-developers mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > |
From: Tim S. <ti...@we...> - 2011-11-22 08:17:18
|
Hi Debi, I really like the idea of expanding on the search methods. A few thoughts: 1 Could we follow the search engine method by allowing boolean operators in the search, and aggregating phrases such as "9/16 Hex" PS for a search string? 2 I have wanted for a long time to implement a soundex (http://en.wikipedia.org/wiki/Soundex) algorithm into our search. A lot of our users in warehouses tend to type in descriptions phonetically, and it would be really great to have it. I'm sure I found some PHP implementations of it before. 3 I know Phil will hate this, but can't we take the item search facility out into a separate function so that it can be reused identically throughout webERP? As Debi points out a change to the search algorithm affects so many parts of webERP and we now have a situation where the implementations of item search are not consistent. Thanks Tim On 22 November 2011 01:39, DebiCates <deb...@ya...> wrote: > Klaus, now that you mention it, I can envision the possible unexpected > headache this change might cause for current users. It would be best > included as an option. > > For example, two parts with descriptions > 5/16 HEX SL PS SCREW 9/16 SS BAND > 9/16 HEX SL PS SCREW 3/32 SS BAND > > Under the current search query, the user could rely that entering 9/16 SCREW > will find only the second item. With my change, of course it finds both. For > us, the limitation of keyword order (often netting NO results) was more > frustrating than too many. I figured there might be others with the same > issue. > > It would be nice to devise a solution that would accommodate both types of > search. Perhaps entering *9/16 SCREW* could signify an in-order search like > it works now. A literal search signifier would be undoubtedly expected then, > too. And a NOT signifier too. Then allowing the user to mix them up in one > search would be an interesting challenge. Like, > > *9/16 SCREW* "SS BAND" #SL# PS > > And it would be even better to use a table to dictate the characters used > for each type of search signifier. Oh, and lastly to include instructions in > the manual! ;) > > This is something I might commit to do. Any other thoughts out there? > > > > -- > View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4094151.html > Sent from the web-ERP-developers mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > -- WebERP Africa Ltd +447710427049 +254706554559 www.weberpafrica.com |
From: Phil D. <ph...@lo...> - 2011-11-22 09:15:54
|
You may need to sit Tim ... I agree with 1 and 3 completely! If we could pass a series of parameters for the search and return a recordset then it could be possible to make it into an SQL_CommonFunctions.inc function that we could re-use everywhere. I even though so at the time I made some of the later scripts realising I was duplicating work with cut and paste, I just never got around to it. I would hate to add too much complexity to item searches but it would be wonderful to have them all consistent and using the same code - removing a chunk out of all those scripts Debi has highlighted. Phil Phil Daintree Logic Works Ltd - +64 (0)275 567890 http://www.logicworks.co.nz On 22/11/11 21:17, Tim Schofield wrote: > Hi Debi, > > I really like the idea of expanding on the search methods. A few thoughts: > > 1 Could we follow the search engine method by allowing boolean > operators in the search, and aggregating phrases such as > > "9/16 Hex" PS > > for a search string? > > 2 I have wanted for a long time to implement a soundex > (http://en.wikipedia.org/wiki/Soundex) algorithm into our search. A > lot of our users in warehouses tend to type in descriptions > phonetically, and it would be really great to have it. I'm sure I > found some PHP implementations of it before. > > 3 I know Phil will hate this, but can't we take the item search > facility out into a separate function so that it can be reused > identically throughout webERP? As Debi points out a change to the > search algorithm affects so many parts of webERP and we now have a > situation where the implementations of item search are not consistent. > > Thanks > Tim > > > On 22 November 2011 01:39, DebiCates<deb...@ya...> wrote: >> Klaus, now that you mention it, I can envision the possible unexpected >> headache this change might cause for current users. It would be best >> included as an option. >> >> For example, two parts with descriptions >> 5/16 HEX SL PS SCREW 9/16 SS BAND >> 9/16 HEX SL PS SCREW 3/32 SS BAND >> >> Under the current search query, the user could rely that entering 9/16 SCREW >> will find only the second item. With my change, of course it finds both. For >> us, the limitation of keyword order (often netting NO results) was more >> frustrating than too many. I figured there might be others with the same >> issue. >> >> It would be nice to devise a solution that would accommodate both types of >> search. Perhaps entering *9/16 SCREW* could signify an in-order search like >> it works now. A literal search signifier would be undoubtedly expected then, >> too. And a NOT signifier too. Then allowing the user to mix them up in one >> search would be an interesting challenge. Like, >> >> *9/16 SCREW* "SS BAND" #SL# PS >> >> And it would be even better to use a table to dictate the characters used >> for each type of search signifier. Oh, and lastly to include instructions in >> the manual! ;) >> >> This is something I might commit to do. Any other thoughts out there? >> >> >> >> -- >> View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4094151.html >> Sent from the web-ERP-developers mailing list archive at Nabble.com. >> >> ------------------------------------------------------------------------------ >> All the data continuously generated in your IT infrastructure >> contains a definitive record of customers, application performance, >> security threats, fraudulent activity, and more. Splunk takes this >> data and makes sense of it. IT sense. And common sense. >> http://p.sf.net/sfu/splunk-novd2d >> _______________________________________________ >> Web-erp-developers mailing list >> Web...@li... >> https://lists.sourceforge.net/lists/listinfo/web-erp-developers >> > > > |
From: DebiCates <deb...@ya...> - 2011-11-22 13:16:56
|
After making all those changes, you bet I love the idea of moving the inventory search over to a function or its own include! While making these changes, not only was it repetitive but I discovered a number of functional inconsistencies. The most important one for us was the lack of Stock Category search across the board. And even when there is a Stock Category search, sometimes it doesn't offer the "ALL" option. We rely heavily on Stock Categories to give more meaning to our inventory results which can be mind-boggingly similar. I'd love to see the inventory search made uniform in every instance and have offered to do that project. Phil, I do understand Klaus's request; making changes to the search functionality as an option could save a lot of grief for loyal users who have perhaps built their inventory descriptions based on the current methodology. Tim, I don't currently have the need for Soundex. That's because in order to stay within the 50 character limit, our descriptions are abbreviated to the point of madness! ha. But as long as Soundex could be invoked as an option, why not? -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4095616.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: Tim S. <ti...@we...> - 2011-11-22 15:02:54
|
Hi Debi, On 22 November 2011 13:16, DebiCates <deb...@ya...> wrote: > Tim, I don't currently have the need for Soundex. That's because in order to > stay within the 50 character limit, our descriptions are abbreviated to the > point of madness! ha. But as long as Soundex could be invoked as an option, > why not? > Wouldn't searching on the Long Description field be an all round better solution then? Where the 50 characters is sufficient then people tend to use the same description in both, where 50 isn't enough then searching on the long description makes more sense? Thanks Tim -- WebERP Africa Ltd +447710427049 +254706554559 www.weberpafrica.com |
From: DebiCates <deb...@ya...> - 2011-11-22 16:02:56
|
Excellent point, Tim. In our case, we have developed our short description to use abbreviations, our long description does not -- the long description we envisioned using in a possible online catalog. For example, the long description is "stainless steel," the short description is "ss." Imagine a guy that is adept at crimping hoses, but not typing on a keyboard. Or a salesman using a touchscreen tablet in the field. Conserving keystrokes for these users matters a lot. But I do emphatically agree it would be nice to have a long description search! Maybe something as simple as a check box beside the description text box to switch to searching on the long description? And in that case, an option in the configuration dictating whether that box is selected or not selected by default would be prudent. Or better yet, in the user configuration... How these "simple" suggestions grow, eh?! -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4096245.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: DebiCates <deb...@ya...> - 2011-11-22 16:07:34
|
While discussing this, it seems like a good time to ask a question related to the short and long description. Why is entering a long description forced? -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4096267.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: Fred Schuettler[alt] <ag...@em...> - 2011-11-22 16:29:53
|
Has anyone noticed the demo server having the following message: *Too many failed login attempts* *You will have to see an authorised person to obtain access to the system* On 11/22/2011 11:07 AM, DebiCates wrote: > While discussing this, it seems like a good time to ask a question related to > the short and long description. Why is entering a long description forced? > > -- > View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4096267.html > Sent from the web-ERP-developers mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > |
From: Tim S. <ti...@we...> - 2011-11-22 08:40:43
|
On 22 November 2011 08:17, Tim Schofield <ti...@we...> wrote: > Hi Debi, > > 2 I have wanted for a long time to implement a soundex > (http://en.wikipedia.org/wiki/Soundex) algorithm into our search. A > lot of our users in warehouses tend to type in descriptions > phonetically, and it would be really great to have it. I'm sure I > found some PHP implementations of it before. > Of course I should point out that soundex searches make no sense with languages that use none phonetic characters such as Chinese. I'm not sure what happens with these?? -- WebERP Africa Ltd +447710427049 +254706554559 www.weberpafrica.com |
From: Tim S. <ti...@we...> - 2011-11-22 13:06:05
|
On 22 November 2011 08:40, Tim Schofield <ti...@we...> wrote: > On 22 November 2011 08:17, Tim Schofield <ti...@we...> wrote: >> Hi Debi, >> >> 2 I have wanted for a long time to implement a soundex >> (http://en.wikipedia.org/wiki/Soundex) algorithm into our search. A >> lot of our users in warehouses tend to type in descriptions >> phonetically, and it would be really great to have it. I'm sure I >> found some PHP implementations of it before. >> > > Of course I should point out that soundex searches make no sense with > languages that use none phonetic characters such as Chinese. I'm not > sure what happens with these?? > Apologies for keeping replying to my own messages, but PHP does actually have a soundex function. http://php.net/manual/en/function.soundex.php so writing it into the search shouldn't be that hard. Its amazing how many new PHP functions I keep finding even now :-) -- WebERP Africa Ltd +447710427049 +254706554559 www.weberpafrica.com |
From: opto <bu...@op...> - 2011-11-22 14:41:54
|
there is another search inconsistency across the user interface: some screens allow to omit the search string, giving as a result the full list. Others insist on entering at least a letter. The first behaviour is desirable for situations where one does not remember the stock code or its first letter. I don't remember at the moment which screens behave out of order but remember I put it into a post a few months ago. Klaus -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4095923.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: DebiCates <deb...@ya...> - 2011-11-22 15:38:16
|
Klaus, I agree that should also be fixed. It sounds to me like moving the inventory search to a function or it own include would be a lovely step toward consistency and a perfect step toward easier enhancements. -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4096150.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: Tim S. <ti...@we...> - 2011-11-22 16:28:32
|
Hi Debi, I agree about the crimping man and his typing which is one reason why I was interested in a soundex solution. In kiswahili (the language used by a lot of employees at our customers) many technical words have phonetic spellings of their English counterparts. For instance a computer becomes a kompyuta which you can imagine leads to a lot of confusion. Management generally wants the spellings in English, but the employees natural instinct is to type in the kiswahili word, indeed they may not know that it is spelt differently as they sound the same. It would be nice for them to be able to search for a kompyuta and be able to see a computer. Thanks Tim On 22 November 2011 16:02, DebiCates <deb...@ya...> wrote: > Excellent point, Tim. > > In our case, we have developed our short description to use abbreviations, > our long description does not -- the long description we envisioned using in > a possible online catalog. For example, the long description is "stainless > steel," the short description is "ss." Imagine a guy that is adept at > crimping hoses, but not typing on a keyboard. Or a salesman using a > touchscreen tablet in the field. Conserving keystrokes for these users > matters a lot. > > But I do emphatically agree it would be nice to have a long description > search! Maybe something as simple as a check box beside the description text > box to switch to searching on the long description? And in that case, an > option in the configuration dictating whether that box is selected or not > selected by default would be prudent. Or better yet, in the user > configuration... > > How these "simple" suggestions grow, eh?! > > -- > View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4096245.html > Sent from the web-ERP-developers mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > -- WebERP Africa Ltd +447710427049 +254706554559 www.weberpafrica.com |
From: DebiCates <deb...@ya...> - 2011-11-22 17:39:40
|
That was interesting, Tim. I see now why soundex would be such a big help to your installations. So, how about a drop down menu next to the description that allows the user to specify what kind of search they'd like to conduct? For convenience, the menu would default to the preference stored in the user profile. That drop menu could contain the following options (so far): Enhanced Search: short description Enhanced Search: long description Soundex Search: short description Soundex Search: long description Pre v4.0X Search: short description Pre v4.0X Search: long description The last search would conduct searches as currently performed, as per Klaus's suggestion. I'm not sure what term to use for that kind of search. I also had the idea of a table-driven list that sets what character to use for a literal search (eg. "") and other Boolean operators. This could be a company-wide setting. Actually, that might be taking configurability to an unnecessary nth degree, I'm not sure. -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Script-changes-to-enhance-inventory-description-search-regardless-of-keyword-order-tp4091940p4096556.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |