From: rfthomas <rf...@as...> - 2014-07-30 15:34:34
|
Our AMP implementation is very strict with respect to include handling. All php code sections must be terminated properly with ?>. On every webERP distribution, including 4.11.3, we find a number of files missing this termination. It is time consuming to check every file for proper termination. There are a number of files in /includes that are not properly terminated. In addition in /includes/tcpdf..., /includes/phpplot..., /includes/barcodepack..., /doc/manual... .php and .inc files are missing the ?> terminator in many cases. We recognize that some php implementations relax this requirement, but having such is good programming practice, and in our case a rigid requirement. Placing ?> terminator in these files works in all implementations. Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/missing-from-many-inc-and-php-files-tp4657576.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
From: gilberto d. s. a. <gs...@gm...> - 2014-07-30 20:54:56
|
i also agree. 2014-07-30 12:34 GMT-03:00 rfthomas <rf...@as...>: > Our AMP implementation is very strict with respect to include handling. > All > php code sections must be terminated properly with ?>. On every webERP > distribution, including 4.11.3, we find a number of files missing this > termination. It is time consuming to check every file for proper > termination. There are a number of files in /includes that are not > properly > terminated. In addition in /includes/tcpdf..., /includes/phpplot..., > /includes/barcodepack..., /doc/manual... .php and .inc files are missing > the > ?> terminator in many cases. > > We recognize that some php implementations relax this requirement, but > having such is good programming practice, and in our case a rigid > requirement. Placing ?> terminator in these files works in all > implementations. > > Bob Thomas > > > > > > -- > View this message in context: > http://weberp-accounting.1478800.n4.nabble.com/missing-from-many-inc-and-php-files-tp4657576.html > Sent from the web-ERP-developers mailing list archive at Nabble.com. > > > ------------------------------------------------------------------------------ > Infragistics Professional > Build stunning WinForms apps today! > Reboot your WinForms applications with our WinForms controls. > Build a bridge from your legacy apps to the future. > > http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > -- gilberto dos santos alves +55.11.98646-5049 sao paulo - sp - brasil |
From: Phil D. <ph...@lo...> - 2014-08-02 05:07:32
|
Bob, Would be interested to see if you get anywhere with your performance issues relative to previous versions. I can really understand why this should be. With tcpdf it is of course an external library and I've tried not to mess with it really. I am working on updating it to the latest tcpdf version - but a bit fearful of stuffing up the clever multi-language/CID font stuff that was done by Javier. I have added closing ?> tags though to aid compliance with strict PHP implementations. I am only including as little of tcpdf distribution that I can. Phil Phil Daintree Logic Works Ltd - +64 (0)275 567890 http://www.logicworks.co.nz On 31/07/14 03:34, rfthomas wrote: > Our AMP implementation is very strict with respect to include handling. All > php code sections must be terminated properly with ?>. On every webERP > distribution, including 4.11.3, we find a number of files missing this > termination. It is time consuming to check every file for proper > termination. There are a number of files in /includes that are not properly > terminated. In addition in /includes/tcpdf..., /includes/phpplot..., > /includes/barcodepack..., /doc/manual... .php and .inc files are missing the > ?> terminator in many cases. > > We recognize that some php implementations relax this requirement, but > having such is good programming practice, and in our case a rigid > requirement. Placing ?> terminator in these files works in all > implementations. > > Bob Thomas > > > > > > -- > View this message in context:http://weberp-accounting.1478800.n4.nabble.com/missing-from-many-inc-and-php-files-tp4657576.html > Sent from the web-ERP-developers mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > Infragistics Professional > Build stunning WinForms apps today! > Reboot your WinForms applications with our WinForms controls. > Build a bridge from your legacy apps to the future. > http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > |