Menu
▾
▴
web-erp-developers
|
From: rfthomas <rf...@as...> - 2015-10-22 22:12:37
|
We are using 4.12.3 and find that includes/GetPrice.inc returns a 0.00 price for items if the customer price list is not the default. The Discount Matrix is properly set-up, but ignored. We have restored the version of GetPrice from /* $Id: GetPrice.inc 6714 2014-05-17 03:09:03Z daintree $*/ removing the ,$db, and everything works as expected. -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: ExsonQu <hex...@gm...> - 2015-10-31 11:05:23
|
*Hi, Bob,*
Would you describe your problem more clearly? What do you mean
customer price list is not the default?
Best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658371.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: rfthomas <rf...@as...> - 2015-11-04 14:18:45
|
Exson, We restored GetPrice.inc from 4.12.3 distribution. It always returns 0.0 from GetPrice.inc for any sales types other than that which is the default sales type. Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658395.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: rfthomas <rf...@as...> - 2015-11-02 14:42:52
|
Exson,
We have list of customer types for example:
Default
End User
OEM
Sales Types:
End User
End User 10%
OEM/Integrator
Discount Matrix with information for each of the sales types, using discount
categories, quantity break and discount rate.
We have customers setup with customer type and sales type code.
When a quote is prepared the Sales Type should cause prices to be generated
based on the Discount Matrix. In the base 4.12.3 code when creating a
quotation the only prices available are the Default. In our system Default
is the End User price. The price should be calculated by applying the
Sales Type Discount Matric against the Default price (in our case End User).
We have reverted to the prior release code that correctly calculates the
prices:
/* $Id: GetPrice.inc 6941 2014-10-26 23:18:08Z daintree $*/
Sincerely,
Robert F. Thomas
44 Industrial Way
Norwood, MA USA 02062
* Office Phone - (781) 329-9200
* mail to: rf...@as...
From: ExsonQu [via webERP accounting]
[mailto:ml-...@n4...]
Sent: Saturday, October 31, 2015 6:53 AM
To: rfthomas <rf...@as...>
Subject: Re: Quotation Prices incorrect
Hi, Bob,
Would you describe your problem more clearly? What do you mean
customer price list is not the default?
Best regards!
Exson
_____
If you reply to this email, your message will be added to the discussion
below:
http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp
4658352p4658371.html
To unsubscribe from Quotation Prices incorrect, click here
<http://weberp-accounting.1478800.n4.nabble.com/template/NamlServlet.jtp?mac
ro=unsubscribe_by_code&node=4658352&code=cmZ0QGFzdGhvbWFzLmNvbXw0NjU4MzUyfC0
xODc0MzAxMjU=> .
<http://weberp-accounting.1478800.n4.nabble.com/template/NamlServlet.jtp?mac
ro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.names
paces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.we
b.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.nam
l-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.n
aml> NAML
image003.png (51K) <http://weberp-accounting.1478800.n4.nabble.com/attachment/4658375/0/image003.png>
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658375.html
Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: ExsonQu <hex...@gm...> - 2015-11-04 22:28:39
|
*Hi, Bob,*
It's not a bug. It's the design of the file.
It's not a general requirement for this feature. When I
asked if someone need this, so we can make it a choice, there is no
feedback. I've got a feedback from webERP chinese community. But what he
want is current discount matrix. Because it's quite tedious to modify the
prices if lots of prices changed.
The file I changed last time can be used. But it'll not
be merged to the trunk.
Best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658397.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: ExsonQu <hex...@gm...> - 2015-11-02 22:58:47
|
*Hi, Bob,*
Would you like to post your reworked copy?
I cannot find what goes wrong. The latest version and the
version (6714) what you said OK has no big difference except $db. The
previous version only removed two lines of debug messages.
Thanks and best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658379.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: rfthomas <rf...@as...> - 2015-11-04 22:57:21
|
Exson, We did not change what we were doing and it is per the documentation and file design. The behavior of GetPrice.php changed, breaking something that worked per the documentation. We have been studying the code. It is not obvious why Get Price.inc is not finding the price. The order of inquiries has changed possibly causing the problem. We have a number of sales types. When we change the default price, the pricing in all of the other sales types properly reflect the change. We will try to see where in GetPrice the error was introduced and post a correction to the community such that no other pricing structures are disturbed. Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658399.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: rfthomas <rf...@as...> - 2015-11-02 23:18:55
|
Exson, The attached was in the original download of V4.12.3 that we performed. GetPrice.inc <http://weberp-accounting.1478800.n4.nabble.com/file/n4658380/GetPrice.inc> Could there have been a corrupt version that was corrected after we downloaded the package? If the current production version is identical to what we are using then there must have been an issue with the downloaded package. Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658380.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: ExsonQu <hex...@gm...> - 2015-11-04 23:23:39
|
*Hi, Bob,*
As your finding, the order of the sql inquiry is the problem
you entered. The sql order reflects the sales type priority. The version of
the price matrix as the first priority exists very short time in the trunk
and it has never been released publicly.
If it's not a generally used feature, it's not suitable to
merge to trunk. At least currently, there are little feedback about this.
Best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658401.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: rfthomas <rf...@as...> - 2015-11-05 19:22:28
|
Exson, We have made modifications to GetPrice.inc so that it works properly using Sales Type, Discount Matrix and Default Price List. The modifications consist of: 1) Adding a second check against the pricematrix for an end date of "0000-00-00", that was missing from the original script. 2) Adding the inclusive check of the pricematrix. 3) Removing the code that fetches a row, preventing proper completion of the script. GetPrice.inc <http://weberp-accounting.1478800.n4.nabble.com/file/n4658402/GetPrice.inc> The changes made are a correction of incorrect handling of the various pricing methods. They should not change usage for any users. Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658402.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: ExsonQu <hex...@gm...> - 2015-11-02 23:33:15
|
*Hi, Bob,*
Thank you for your quick response!
It's no difference with the trunk!
Would you like to post the file you revised?
Best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658381.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: ExsonQu <hex...@gm...> - 2015-11-03 05:33:50
|
*Hi, Bob,*
I've revised the GetPrice.php.
I think it will work for you!
PriceMatrix.zip
<http://weberp-accounting.1478800.n4.nabble.com/file/n4658385/PriceMatrix.zip>
Best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658385.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: rfthomas <rf...@as...> - 2015-11-03 13:29:17
|
Exson, You provided PriceMatrix.php. We have replaced the existing PriceMatrix.php and see no problem in a quick test, but we are using the following GetPrice.inc: GetPrice.inc <http://weberp-accounting.1478800.n4.nabble.com/file/n4658387/GetPrice.inc> Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658387.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
|
From: ExsonQu <hex...@gm...> - 2015-11-04 02:09:52
|
*Hi, Bob,*
I've checked your file. And it's not the version you mentioned.
Since there is no response to revise the feature, I'll keep it
as is.
Thanks and best regards!
Exson
--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658392.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.
|
|
From: rfthomas <rf...@as...> - 2015-11-04 13:55:00
|
Exson, Could you send me the current production version of GetPrice.php so that we can test? We use the sales type and discount matrix to obtain all of our pricing. We do not have customer unique prices so we need GetPrice.php to properly handle this situation. The issues with GetPrice.php have been a problem for several releases of webERP. It appears that the error in GetPrice.php was introduced sometime between 4.11.5 and 4.12.2. Bob Thomas -- View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Quotation-Prices-incorrect-tp4658352p4658394.html Sent from the web-ERP-developers mailing list archive at Nabble.com. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X