web-erp-developers

[Web-erp-developers] Re: input & goods received mods

[Phil D. <we...@pa...>]

Huge enthusiasm boost!!
Thanks Jesse.

I came accross a couple of links that were stuffed by the change to '
rather than " and a missed < somewhere but so easy to apply with a diff
and the files themselves - it is just a question of reviewing the diff
and copying the file!!

Would you have any more time for other scripts perhaps staying with the
controlled/serialized stuff??

StockAdjustments.php
StockAdjustmentsControlled.php
StockTransferControlled.php
StockTransfers.php


For the benefit of the rest of the crew ... these are now in CVS - all
gettextified thanks to Jesse

GoodsReceived.php
GoodsReceivedControlled.php 
and accompanying includes
includes/InputSerialItems.php
includes/InputSerialItemsKeyed.php
includes/InputSerialItemsFile.php


I also managed to enslist Victor off the user list and he has _ified

Customers.php

Together with my own meagre efforts:

AccountGroups.php
AgedDebtors.php  includes/PDFAgedDebtorsPageHeader.inc
AgedSuppliers.php includes/PDFAgedSuppliersPageHeader.inc

So we are rattling through them!

Phil


On Sun, 2004-09-05 at 18:17, Jesse Peterson wrote:
> I've attached a diff of my changes as well as the full files.
> 
> Most all of the changes are for translations and changing "s to 's. The 
> form setting 'enctype' that fixed my upload issue is included, and a 
> small error in an upgrade script is as well.
> 
> These changes are against cvs pulled around 9/14 16:19 EDT.
> 
> 
> jesse

Re: [Web-erp-developers] Re: input & goods received mods

[Phil D. <we...@pa...>]

> I don't have this problem ... I even see some scripts I am running out 
> of yesterday's CVS  have this change made and seem to work fine. Steve, 
> maybe this is a result of mucking with the session.auto_start variable 
> you mentioned in a post some days ago?? For the record, I am running 
> under php 4.3.4 .
> 

Steve,

With session.auto_start I would have thought php would have started the
session before it gets to parse the set php.ini bit? I haven't tried it
and it sure would limit the scope for problems. I'll give it a go when
we are translated.

Phil

RE: [Web-erp-developers] Re: input & goods received mods

[Jesse P. <je...@st...>]

Ok, I took another look and realized I was just foolish in my original =
post. You probably don't have gettext enabled.... I never actually =
looked, only grep'd to see if the gettext stuff is in session.inc - it =
is included in session.inc . Not having that function defined when =
gettext is not functional has to be what is causing you problem.=20
So, I imagine to make Language support work across the board, your =
original statement that session.inc needs to be the first include in =
every script is dead-on.
Sorry to have caused doubt/confusion.


jesse

-----Original Message-----
From: skaill [mailto:sk...@ro...]
Sent: Tuesday, September 07, 2004 3:51 PM
To: web...@li...
Subject: Re: [Web-erp-developers] Re: input & goods received mods


If I put the $title line at the top before session.inc include then I =
get an
error.  I have not tampered with my session.auto_start or any other php
settings.  That was just information I passed on the other day but did =
not
try.  I'm thinking since the _() function is defined in session.inc as =
far
as I see this would mean that the $title translation call is before the
translation _() function is defined.  I can't remember if php sees all
functions in the includes whether before encountered or not though.  I'm
thinking not.

The error is

Fatal error: Call to undefined function: _() in
/home/weberp/public_html/weberpcvstest/BankAccounts.php on line 4

when $title is before the session.inc include.

Steve

----- Original Message -----=20
From: "Jesse Peterson" <je...@st...>
To: <web...@li...>
Sent: Monday, September 06, 2004 11:54 AM
Subject: Re: [Web-erp-developers] Re: input & goods received mods


>
> >That is interesting that you had to include session.inc before $title
> >was set. This doesn't appear necessary in php 5 and I have not done =
this
> >in the scripts I have modified - I will go back and modify them. I
> >thought it would be necessary initially.
> >
> >
> I don't have this problem ... I even see some scripts I am running out
> of yesterday's CVS  have this change made and seem to work fine. =
Steve,
> maybe this is a result of mucking with the session.auto_start variable
> you mentioned in a post some days ago?? For the record, I am running
> under php 4.3.4 .

Re: [Web-erp-developers] Re: input & goods received mods

[skaill <sk...@ro...>]

Couldn't say I was sure so I'm glad we figured out what was happening for
sure.

Just to emphasize, I'll repeat what you said so everyone knows or all the
pages will be incorrect.

Whoever is doing the pages for Multilanguage needs to move the line that
sets $title to a string near the top of every page to after the session.inc
include but before header.inc.  header.inc uses $title so it must be set and
translated before header.inc.

Steve

----- Original Message ----- 
From: "Jesse Peterson" <je...@st...>
To: <web...@li...>
Sent: Tuesday, September 07, 2004 4:58 PM
Subject: RE: [Web-erp-developers] Re: input & goods received mods


Ok, I took another look and realized I was just foolish in my original post.
You probably don't have gettext enabled.... I never actually looked, only
grep'd to see if the gettext stuff is in session.inc - it is included in
session.inc . Not having that function defined when gettext is not
functional has to be what is causing you problem.
So, I imagine to make Language support work across the board, your original
statement that session.inc needs to be the first include in every script is
dead-on.
Sorry to have caused doubt/confusion.


jesse

-----Original Message-----
From: skaill [mailto:sk...@ro...]
Sent: Tuesday, September 07, 2004 3:51 PM
To: web...@li...
Subject: Re: [Web-erp-developers] Re: input & goods received mods


If I put the $title line at the top before session.inc include then I get an
error.  I have not tampered with my session.auto_start or any other php
settings.  That was just information I passed on the other day but did not
try.  I'm thinking since the _() function is defined in session.inc as far
as I see this would mean that the $title translation call is before the
translation _() function is defined.  I can't remember if php sees all
functions in the includes whether before encountered or not though.  I'm
thinking not.

The error is

Fatal error: Call to undefined function: _() in
/home/weberp/public_html/weberpcvstest/BankAccounts.php on line 4

when $title is before the session.inc include.

Steve

----- Original Message ----- 
From: "Jesse Peterson" <je...@st...>
To: <web...@li...>
Sent: Monday, September 06, 2004 11:54 AM
Subject: Re: [Web-erp-developers] Re: input & goods received mods


>
> >That is interesting that you had to include session.inc before $title
> >was set. This doesn't appear necessary in php 5 and I have not done this
> >in the scripts I have modified - I will go back and modify them. I
> >thought it would be necessary initially.
> >
> >
> I don't have this problem ... I even see some scripts I am running out
> of yesterday's CVS  have this change made and seem to work fine. Steve,
> maybe this is a result of mucking with the session.auto_start variable
> you mentioned in a post some days ago?? For the record, I am running
> under php 4.3.4 .


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idP47&alloc_id808&op=ick
_______________________________________________
Web-erp-developers mailing list
Web...@li...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers

Re: [Web-erp-developers] Re: input & goods received mods

[Daintrees <p.d...@pa...>]

Darn!! I have done quite a few already!

Phil
----- Original Message ----- 
From: "skaill" <sk...@ro...>
To: <web...@li...>
Sent: Wednesday, September 08, 2004 10:02 AM
Subject: Re: [Web-erp-developers] Re: input & goods received mods


> Couldn't say I was sure so I'm glad we figured out what was happening for
> sure.
>
> Just to emphasize, I'll repeat what you said so everyone knows or all the
> pages will be incorrect.
>
> Whoever is doing the pages for Multilanguage needs to move the line that
> sets $title to a string near the top of every page to after the
session.inc
> include but before header.inc.  header.inc uses $title so it must be set
and
> translated before header.inc.
>
> Steve
>
> ----- Original Message ----- 
> From: "Jesse Peterson" <je...@st...>
> To: <web...@li...>
> Sent: Tuesday, September 07, 2004 4:58 PM
> Subject: RE: [Web-erp-developers] Re: input & goods received mods
>
>
> Ok, I took another look and realized I was just foolish in my original
post.
> You probably don't have gettext enabled.... I never actually looked, only
> grep'd to see if the gettext stuff is in session.inc - it is included in
> session.inc . Not having that function defined when gettext is not
> functional has to be what is causing you problem.
> So, I imagine to make Language support work across the board, your
original
> statement that session.inc needs to be the first include in every script
is
> dead-on.
> Sorry to have caused doubt/confusion.
>
>
> jesse
>
> -----Original Message-----
> From: skaill [mailto:sk...@ro...]
> Sent: Tuesday, September 07, 2004 3:51 PM
> To: web...@li...
> Subject: Re: [Web-erp-developers] Re: input & goods received mods
>
>
> If I put the $title line at the top before session.inc include then I get
an
> error.  I have not tampered with my session.auto_start or any other php
> settings.  That was just information I passed on the other day but did not
> try.  I'm thinking since the _() function is defined in session.inc as far
> as I see this would mean that the $title translation call is before the
> translation _() function is defined.  I can't remember if php sees all
> functions in the includes whether before encountered or not though.  I'm
> thinking not.
>
> The error is
>
> Fatal error: Call to undefined function: _() in
> /home/weberp/public_html/weberpcvstest/BankAccounts.php on line 4
>
> when $title is before the session.inc include.
>
> Steve
>
> ----- Original Message ----- 
> From: "Jesse Peterson" <je...@st...>
> To: <web...@li...>
> Sent: Monday, September 06, 2004 11:54 AM
> Subject: Re: [Web-erp-developers] Re: input & goods received mods
>
>
> >
> > >That is interesting that you had to include session.inc before $title
> > >was set. This doesn't appear necessary in php 5 and I have not done
this
> > >in the scripts I have modified - I will go back and modify them. I
> > >thought it would be necessary initially.
> > >
> > >
> > I don't have this problem ... I even see some scripts I am running out
> > of yesterday's CVS  have this change made and seem to work fine. Steve,
> > maybe this is a result of mucking with the session.auto_start variable
> > you mentioned in a post some days ago?? For the record, I am running
> > under php 4.3.4 .
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idP47&alloc_id808&op=ick
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>

Re: [Web-erp-developers] Re: input & goods received mods

[Phil D. <we...@pa...>]

Only one other point to add guys

session.inc must be included after 

$PageSecurity = x;

$PageSecurity is checked to see if the user is authorised inside
session.inc


Phil


On Wed, 2004-09-08 at 10:02, skaill wrote:
> Couldn't say I was sure so I'm glad we figured out what was happening for
> sure.
> 
> Just to emphasize, I'll repeat what you said so everyone knows or all the
> pages will be incorrect.
> 
> Whoever is doing the pages for Multilanguage needs to move the line that
> sets $title to a string near the top of every page to after the session.inc
> include but before header.inc.  header.inc uses $title so it must be set and
> translated before header.inc.
> 
> Steve
> 
> ----- Original Message ----- 
> From: "Jesse Peterson" <je...@st...>
> To: <web...@li...>
> Sent: Tuesday, September 07, 2004 4:58 PM
> Subject: RE: [Web-erp-developers] Re: input & goods received mods
> 
> 
> Ok, I took another look and realized I was just foolish in my original post.
> You probably don't have gettext enabled.... I never actually looked, only
> grep'd to see if the gettext stuff is in session.inc - it is included in
> session.inc . Not having that function defined when gettext is not
> functional has to be what is causing you problem.
> So, I imagine to make Language support work across the board, your original
> statement that session.inc needs to be the first include in every script is
> dead-on.
> Sorry to have caused doubt/confusion.
> 
> 
> jesse
> 
> -----Original Message-----
> From: skaill [mailto:sk...@ro...]
> Sent: Tuesday, September 07, 2004 3:51 PM
> To: web...@li...
> Subject: Re: [Web-erp-developers] Re: input & goods received mods
> 
> 
> If I put the $title line at the top before session.inc include then I get an
> error.  I have not tampered with my session.auto_start or any other php
> settings.  That was just information I passed on the other day but did not
> try.  I'm thinking since the _() function is defined in session.inc as far
> as I see this would mean that the $title translation call is before the
> translation _() function is defined.  I can't remember if php sees all
> functions in the includes whether before encountered or not though.  I'm
> thinking not.
> 
> The error is
> 
> Fatal error: Call to undefined function: _() in
> /home/weberp/public_html/weberpcvstest/BankAccounts.php on line 4
> 
> when $title is before the session.inc include.
> 
> Steve
> 
> ----- Original Message ----- 
> From: "Jesse Peterson" <je...@st...>
> To: <web...@li...>
> Sent: Monday, September 06, 2004 11:54 AM
> Subject: Re: [Web-erp-developers] Re: input & goods received mods
> 
> 
> >
> > >That is interesting that you had to include session.inc before $title
> > >was set. This doesn't appear necessary in php 5 and I have not done this
> > >in the scripts I have modified - I will go back and modify them. I
> > >thought it would be necessary initially.
> > >
> > >
> > I don't have this problem ... I even see some scripts I am running out
> > of yesterday's CVS  have this change made and seem to work fine. Steve,
> > maybe this is a result of mucking with the session.auto_start variable
> > you mentioned in a post some days ago?? For the record, I am running
> > under php 4.3.4 .
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idP47&alloc_id808&op=ick
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
> 

Re: [Web-erp-developers] Re: input & goods received mods

[Jesse P. <je...@st...>]

I'll see what I can do there.
I am walking the file upload stuff through the various stages (po, 
invoice, etc), so you may get some of the files I am in first or 
interspersed. I can see from the previous list you handed out to people 
that some of my changes may conflict with theirs, especially since I'm 
working in ConfirmDispatch* right now...

jesse

>Would you have any more time for other scripts perhaps staying with the
>controlled/serialized stuff??
>
>StockAdjustments.php
>StockAdjustmentsControlled.php
>StockTransferControlled.php
>StockTransfers.php
>
>  
>

Re: [Web-erp-developers] Re: input & goods received mods

[Phil D. <we...@pa...>]

Steve,

That script looks fine - I have tested and updated the CVS.

This is a difficulty with the approach - we can only xgettext the
strings to translate having modified the code to perform the translation
- so we cannot actually test the translation code works until we create
the messages.po file get the msgstr translated and create a messages.mo
file. I have proved the concept though and if you update your cvs and
switch to italian you should see my foolish translations of a couple of
menu items! As I get these scripts I will extract the strings and build
up our messages.po file ready for translation.

In our case the modification of the scripts as you describe is required
first - the translation itself is not testable until we have a
messages.po and all the strings have been translated - also a massive
job! 

That is interesting that you had to include session.inc before $title
was set. This doesn't appear necessary in php 5 and I have not done this
in the scripts I have modified - I will go back and modify them. I
thought it would be necessary initially.

The only other thing I would like to acheive is to convert to Jesse's
DB_query with the additional parameters - this actually reduces a fair
amount of repeated code - wish I'd thought of it before really. Need to
be a little careful inside pdf scripts though.



Phil


On Mon, 2004-09-06 at 03:30, skaill wrote:
> Hi Phil,
> 
> Here's my first Multilanguage file.  It is BankAccounts.  Would you be able
> to check it out and let me know if I'm doing everything right.  What I
> understand is
> 
> 1) Change all the strings to be encapsulated by the _() translation function
> call.  These would be in echo and printf statements as well as comparisons
> possibly but one must be careful about them.  Also table column headers,
> field labels and such within the html.
> 
> 2)  Check to make sure any submits are using isset to avoid translation.
> I'm assuming here that you haven't overloaded multiple submit buttons with
> the same name but different values.
> 
> 3) Changing the double quotes to single quotes for strings wherever possible
> and breaking the strings into pieces where there are variables.
> 
> One concern I have is how to test this properly.  I went as far as putting
> my changes up on our test site and the page looks fine but it isn't doing
> any real translation, it's just coming back with the English.  Who is
> creating the actual language file that we could use to test?
> 
> I ran into two problems and one could be because I haven't updated my cvs in
> a day or two.
> 
> 1) It gave an error the first time it encountered a call to _() saying the
> function didn't exist.  I modified the gettext part in session.inc to
> 
> if (!function_exists('gettext')){
>  function _($text){
>   return $text;
>  }
> } else {
>   function _($text) {
>    return gettext($text);
>  }
> }
> 
> 2) The $title variable is at the top of each script but the include for
> session.inc that defines the _() function is afterward.  So, if you change
> $title to _($title) there is an error about undefined function.  I fixed it
> by moving the $title below the session.inc include but before the header.inc
> which uses $title!
> 
> I know my message is long but I want to get this right from the start
> instead of having to go back through all the files I do a second time.  That
> wouldn't be fun :O
> 
> Steve
> 
> ----- Original Message ----- 
> From: "Phil Daintree" <we...@pa...>
> To: <web...@li...>
> Sent: Sunday, September 05, 2004 4:30 AM
> Subject: [Web-erp-developers] Re: input & goods received mods
> 
> 
> > Huge enthusiasm boost!!
> > Thanks Jesse.
> >
> > I came accross a couple of links that were stuffed by the change to '
> > rather than " and a missed < somewhere but so easy to apply with a diff
> > and the files themselves - it is just a question of reviewing the diff
> > and copying the file!!
> >
> > Would you have any more time for other scripts perhaps staying with the
> > controlled/serialized stuff??
> >
> > StockAdjustments.php
> > StockAdjustmentsControlled.php
> > StockTransferControlled.php
> > StockTransfers.php
> >
> >
> > For the benefit of the rest of the crew ... these are now in CVS - all
> > gettextified thanks to Jesse
> >
> > GoodsReceived.php
> > GoodsReceivedControlled.php
> > and accompanying includes
> > includes/InputSerialItems.php
> > includes/InputSerialItemsKeyed.php
> > includes/InputSerialItemsFile.php
> >
> >
> > I also managed to enslist Victor off the user list and he has _ified
> >
> > Customers.php
> >
> > Together with my own meagre efforts:
> >
> > AccountGroups.php
> > AgedDebtors.php  includes/PDFAgedDebtorsPageHeader.inc
> > AgedSuppliers.php includes/PDFAgedSuppliersPageHeader.inc
> >
> > So we are rattling through them!
> >
> > Phil
> >
> >
> > On Sun, 2004-09-05 at 18:17, Jesse Peterson wrote:
> > > I've attached a diff of my changes as well as the full files.
> > >
> > > Most all of the changes are for translations and changing "s to 's. The
> > > form setting 'enctype' that fixed my upload issue is included, and a
> > > small error in an upgrade script is as well.
> > >
> > > These changes are against cvs pulled around 9/14 16:19 EDT.
> > >
> > >
> > > jesse
> >
> >
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by BEA Weblogic Workshop
> > FREE Java Enterprise J2EE developer tools!
> > Get your free copy of BEA WebLogic Workshop 8.1 today.
> > http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> > _______________________________________________
> > Web-erp-developers mailing list
> > Web...@li...
> > https://lists.sourceforge.net/lists/listinfo/web-erp-developers

Re: [Web-erp-developers] Re: input & goods received mods

[Jesse P. <je...@st...>]

>That is interesting that you had to include session.inc before $title
>was set. This doesn't appear necessary in php 5 and I have not done this
>in the scripts I have modified - I will go back and modify them. I
>thought it would be necessary initially.
>  
>
I don't have this problem ... I even see some scripts I am running out 
of yesterday's CVS  have this change made and seem to work fine. Steve, 
maybe this is a result of mucking with the session.auto_start variable 
you mentioned in a post some days ago?? For the record, I am running 
under php 4.3.4 .


jesse

Re: [Web-erp-developers] Re: input & goods received mods

[skaill <sk...@ro...>]

Thanks, Jesse, I'll check it out again.  

Steve

----- Original Message ----- 
From: "Jesse Peterson" <je...@st...>
To: <web...@li...>
Sent: Monday, September 06, 2004 11:54 AM
Subject: Re: [Web-erp-developers] Re: input & goods received mods


> 
> >That is interesting that you had to include session.inc before $title
> >was set. This doesn't appear necessary in php 5 and I have not done this
> >in the scripts I have modified - I will go back and modify them. I
> >thought it would be necessary initially.
> >  
> >
> I don't have this problem ... I even see some scripts I am running out 
> of yesterday's CVS  have this change made and seem to work fine. Steve, 
> maybe this is a result of mucking with the session.auto_start variable 
> you mentioned in a post some days ago?? For the record, I am running 
> under php 4.3.4 .
> 
> 
> jesse
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers

Re: [Web-erp-developers] Re: input & goods received mods

[skaill <sk...@ro...>]

If I put the $title line at the top before session.inc include then I get an
error.  I have not tampered with my session.auto_start or any other php
settings.  That was just information I passed on the other day but did not
try.  I'm thinking since the _() function is defined in session.inc as far
as I see this would mean that the $title translation call is before the
translation _() function is defined.  I can't remember if php sees all
functions in the includes whether before encountered or not though.  I'm
thinking not.

The error is

Fatal error: Call to undefined function: _() in
/home/weberp/public_html/weberpcvstest/BankAccounts.php on line 4

when $title is before the session.inc include.

Steve

----- Original Message ----- 
From: "Jesse Peterson" <je...@st...>
To: <web...@li...>
Sent: Monday, September 06, 2004 11:54 AM
Subject: Re: [Web-erp-developers] Re: input & goods received mods


>
> >That is interesting that you had to include session.inc before $title
> >was set. This doesn't appear necessary in php 5 and I have not done this
> >in the scripts I have modified - I will go back and modify them. I
> >thought it would be necessary initially.
> >
> >
> I don't have this problem ... I even see some scripts I am running out
> of yesterday's CVS  have this change made and seem to work fine. Steve,
> maybe this is a result of mucking with the session.auto_start variable
> you mentioned in a post some days ago?? For the record, I am running
> under php 4.3.4 .
>
>
> jesse
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers

Re: [Web-erp-developers] Re: input & goods received mods

[skaill <sk...@ro...>]

Well, I guess as far as testing we should pill up each changed script and
see if all the English words displayed still appear properly.  This makes
sure we didn't do anything horrible with the string splittings, we haven't
hard coded a variable name in single quotes, etc.

Steve

----- Original Message ----- 
From: "Phil Daintree" <we...@pa...>
To: <web...@li...>
Sent: Monday, September 06, 2004 3:43 AM
Subject: Re: [Web-erp-developers] Re: input & goods received mods


> Steve,
>
> That script looks fine - I have tested and updated the CVS.
>
> This is a difficulty with the approach - we can only xgettext the
> strings to translate having modified the code to perform the translation
> - so we cannot actually test the translation code works until we create
> the messages.po file get the msgstr translated and create a messages.mo
> file. I have proved the concept though and if you update your cvs and
> switch to italian you should see my foolish translations of a couple of
> menu items! As I get these scripts I will extract the strings and build
> up our messages.po file ready for translation.
>
> In our case the modification of the scripts as you describe is required
> first - the translation itself is not testable until we have a
> messages.po and all the strings have been translated - also a massive
> job!
>
> That is interesting that you had to include session.inc before $title
> was set. This doesn't appear necessary in php 5 and I have not done this
> in the scripts I have modified - I will go back and modify them. I
> thought it would be necessary initially.
>
> The only other thing I would like to acheive is to convert to Jesse's
> DB_query with the additional parameters - this actually reduces a fair
> amount of repeated code - wish I'd thought of it before really. Need to
> be a little careful inside pdf scripts though.
>
>
>
> Phil
>
>
> On Mon, 2004-09-06 at 03:30, skaill wrote:
> > Hi Phil,
> >
> > Here's my first Multilanguage file.  It is BankAccounts.  Would you be
able
> > to check it out and let me know if I'm doing everything right.  What I
> > understand is
> >
> > 1) Change all the strings to be encapsulated by the _() translation
function
> > call.  These would be in echo and printf statements as well as
comparisons
> > possibly but one must be careful about them.  Also table column headers,
> > field labels and such within the html.
> >
> > 2)  Check to make sure any submits are using isset to avoid translation.
> > I'm assuming here that you haven't overloaded multiple submit buttons
with
> > the same name but different values.
> >
> > 3) Changing the double quotes to single quotes for strings wherever
possible
> > and breaking the strings into pieces where there are variables.
> >
> > One concern I have is how to test this properly.  I went as far as
putting
> > my changes up on our test site and the page looks fine but it isn't
doing
> > any real translation, it's just coming back with the English.  Who is
> > creating the actual language file that we could use to test?
> >
> > I ran into two problems and one could be because I haven't updated my
cvs in
> > a day or two.
> >
> > 1) It gave an error the first time it encountered a call to _() saying
the
> > function didn't exist.  I modified the gettext part in session.inc to
> >
> > if (!function_exists('gettext')){
> >  function _($text){
> >   return $text;
> >  }
> > } else {
> >   function _($text) {
> >    return gettext($text);
> >  }
> > }
> >
> > 2) The $title variable is at the top of each script but the include for
> > session.inc that defines the _() function is afterward.  So, if you
change
> > $title to _($title) there is an error about undefined function.  I fixed
it
> > by moving the $title below the session.inc include but before the
header.inc
> > which uses $title!
> >
> > I know my message is long but I want to get this right from the start
> > instead of having to go back through all the files I do a second time.
That
> > wouldn't be fun :O
> >
> > Steve
> >
> > ----- Original Message ----- 
> > From: "Phil Daintree" <we...@pa...>
> > To: <web...@li...>
> > Sent: Sunday, September 05, 2004 4:30 AM
> > Subject: [Web-erp-developers] Re: input & goods received mods
> >
> >
> > > Huge enthusiasm boost!!
> > > Thanks Jesse.
> > >
> > > I came accross a couple of links that were stuffed by the change to '
> > > rather than " and a missed < somewhere but so easy to apply with a
diff
> > > and the files themselves - it is just a question of reviewing the diff
> > > and copying the file!!
> > >
> > > Would you have any more time for other scripts perhaps staying with
the
> > > controlled/serialized stuff??
> > >
> > > StockAdjustments.php
> > > StockAdjustmentsControlled.php
> > > StockTransferControlled.php
> > > StockTransfers.php
> > >
> > >
> > > For the benefit of the rest of the crew ... these are now in CVS - all
> > > gettextified thanks to Jesse
> > >
> > > GoodsReceived.php
> > > GoodsReceivedControlled.php
> > > and accompanying includes
> > > includes/InputSerialItems.php
> > > includes/InputSerialItemsKeyed.php
> > > includes/InputSerialItemsFile.php
> > >
> > >
> > > I also managed to enslist Victor off the user list and he has _ified
> > >
> > > Customers.php
> > >
> > > Together with my own meagre efforts:
> > >
> > > AccountGroups.php
> > > AgedDebtors.php  includes/PDFAgedDebtorsPageHeader.inc
> > > AgedSuppliers.php includes/PDFAgedSuppliersPageHeader.inc
> > >
> > > So we are rattling through them!
> > >
> > > Phil
> > >
> > >
> > > On Sun, 2004-09-05 at 18:17, Jesse Peterson wrote:
> > > > I've attached a diff of my changes as well as the full files.
> > > >
> > > > Most all of the changes are for translations and changing "s to 's.
The
> > > > form setting 'enctype' that fixed my upload issue is included, and a
> > > > small error in an upgrade script is as well.
> > > >
> > > > These changes are against cvs pulled around 9/14 16:19 EDT.
> > > >
> > > >
> > > > jesse
> > >
> > >
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.Net email is sponsored by BEA Weblogic Workshop
> > > FREE Java Enterprise J2EE developer tools!
> > > Get your free copy of BEA WebLogic Workshop 8.1 today.
> > > http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> > > _______________________________________________
> > > Web-erp-developers mailing list
> > > Web...@li...
> > > https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers