From: Phil D. <we...@pa...> - 2004-09-04 05:30:06
|
Perfect! I notice you have even changed to single ' to improve performance! I have committed this to the CVS. Many thanks! Could I impose on you for a few more scripts? CustomerReceipt.php CustomerTransInquiry.php Thanks Phil On Sat, 2004-09-04 at 01:02, Victor wrote: > Hi Phil, > > It seems that Customers.php is not a difficult script to be converted > for multi-language support. > Therefore I have made the conversion. Please take a look and let me > know whether there is any mistake. > > Regards, > Victor |
From: Phil D. <we...@pa...> - 2004-09-04 10:36:04
|
Input type=hidden is just a way of holding a value in a html form that gets posted with the other data in the form but is not displayed. Since it is not displayed there is no need to worry about wrapping the Yes in a _() function. Thanks very much for contributing. Phil On Sat, 2004-09-04 at 20:29, Victor wrote: > Hi Phil, > > Thanks! Actually, I am still not sure whether I need to change the code on > lines 201 and 310 for "INPUT TYPE=HIDDEN" and the "VALUE='Yes'" as I do not > fully understand the html language. > I will try the conversion for the two scripts you suggested and send them > back to you on Monday. > > Thanks! > > Victor > > ----- Original Message ----- > From: "Phil Daintree" <we...@pa...> > To: "Victor" <vi...@hi...>; > <web...@li...> > Sent: Saturday, September 04, 2004 1:30 PM > Subject: Re: Converted Customers.php for multi-language support > > > > Perfect! > > I notice you have even changed to single ' to improve performance! > > > > I have committed this to the CVS. > > > > Many thanks! > > > > Could I impose on you for a few more scripts? > > > > CustomerReceipt.php > > CustomerTransInquiry.php > > > > Thanks > > > > Phil > > > > On Sat, 2004-09-04 at 01:02, Victor wrote: > > > Hi Phil, > > > > > > It seems that Customers.php is not a difficult script to be converted > > > for multi-language support. > > > Therefore I have made the conversion. Please take a look and let me > > > know whether there is any mistake. > > > > > > Regards, > > > Victor > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by BEA Weblogic Workshop > FREE Java Enterprise J2EE developer tools! > Get your free copy of BEA WebLogic Workshop 8.1 today. > http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers > |
From: Phil D. <we...@pa...> - 2004-09-07 10:01:00
|
Fantastic! There is only one tiny issue .... calls to the DB_query function like the following: $CustomerResult = DB_query($SQL,$db); if (DB_error_no($db) !=0) { echo _('The customer details could not be retrieved by the SQL because') . ' - ' . DB_error_msg($db); if ($debug==1){ echo '<BR>' . $SQL; } exit; } becomes: $ErrMsg = _('The customer details could not be retrieved because'); $DbgMsg = _('The SQL that failed was'); $CustomerResult = DB_query($SQL,$db,$ErrMsg, $DbgMsg); This was a change made by Jesse to the DB_query function to avoid all the repetition of the first lot of code. I have changed them all over now. Thanks for all your help and I am bound to ask (I am now pushing it a bit) ... would you do a few more? DiscountCategories.php DiscountMatrix.php Phil On Tue, 2004-09-07 at 17:41, Victor wrote: > Hi Phil, > > Yesterday, I could only finish the conversion of CustomerReceipt.php > Today, I also finish the other script CustomerTransInquiry.php > Please check them and let me know whether there is any error. > Thanks! > > Victor > > ----- Original Message ----- > From: "Phil Daintree" <we...@pa...> > To: "Victor" <vi...@hi...>; > <web...@li...> > Sent: Saturday, September 04, 2004 1:30 PM > Subject: Re: Converted Customers.php for multi-language support > > > > Perfect! > > I notice you have even changed to single ' to improve performance! > > > > I have committed this to the CVS. > > > > Many thanks! > > > > Could I impose on you for a few more scripts? > > > > CustomerReceipt.php > > CustomerTransInquiry.php > > > > Thanks > > > > Phil > > > > On Sat, 2004-09-04 at 01:02, Victor wrote: > > > Hi Phil, > > > > > > It seems that Customers.php is not a difficult script to be converted > > > for multi-language support. > > > Therefore I have made the conversion. Please take a look and let me > > > know whether there is any mistake. > > > > > > Regards, > > > Victor > > |
From: Victor <vi...@hi...> - 2004-09-04 08:26:36
|
Hi Phil, Thanks! Actually, I am still not sure whether I need to change the code on lines 201 and 310 for "INPUT TYPE=HIDDEN" and the "VALUE='Yes'" as I do not fully understand the html language. I will try the conversion for the two scripts you suggested and send them back to you on Monday. Thanks! Victor ----- Original Message ----- From: "Phil Daintree" <we...@pa...> To: "Victor" <vi...@hi...>; <web...@li...> Sent: Saturday, September 04, 2004 1:30 PM Subject: Re: Converted Customers.php for multi-language support > Perfect! > I notice you have even changed to single ' to improve performance! > > I have committed this to the CVS. > > Many thanks! > > Could I impose on you for a few more scripts? > > CustomerReceipt.php > CustomerTransInquiry.php > > Thanks > > Phil > > On Sat, 2004-09-04 at 01:02, Victor wrote: > > Hi Phil, > > > > It seems that Customers.php is not a difficult script to be converted > > for multi-language support. > > Therefore I have made the conversion. Please take a look and let me > > know whether there is any mistake. > > > > Regards, > > Victor > |
From: Victor <vi...@hi...> - 2004-09-07 05:42:01
Attachments:
CustomerReceipt.php
CustomerTransInquiry.php
|
Hi Phil, Yesterday, I could only finish the conversion of CustomerReceipt.php Today, I also finish the other script CustomerTransInquiry.php Please check them and let me know whether there is any error. Thanks! Victor ----- Original Message ----- From: "Phil Daintree" <we...@pa...> To: "Victor" <vi...@hi...>; <web...@li...> Sent: Saturday, September 04, 2004 1:30 PM Subject: Re: Converted Customers.php for multi-language support > Perfect! > I notice you have even changed to single ' to improve performance! > > I have committed this to the CVS. > > Many thanks! > > Could I impose on you for a few more scripts? > > CustomerReceipt.php > CustomerTransInquiry.php > > Thanks > > Phil > > On Sat, 2004-09-04 at 01:02, Victor wrote: > > Hi Phil, > > > > It seems that Customers.php is not a difficult script to be converted > > for multi-language support. > > Therefore I have made the conversion. Please take a look and let me > > know whether there is any mistake. > > > > Regards, > > Victor > |