Re: [Web-erp-developers] po tidy up

[Phil D. <we...@pa...>]

Kitch,

Since I imagine you'll be modifying a gazillion scripts I will not do any more 
until you send me what you have done.

I must say you sure are a man who knows how to roll his sleeves up!

Phil

On Friday 19 November 2004 07:48, Steve Kitchen wrote:
> OK, I've had a look at all this stuff and here's the low-down ....
>
>
> As Phil says, things are somewhat messy with duplicate definitions, bits
> of puctuation, bits of HTML and the like in the text strings.
>
> I will go through all the existing modules and bash it into a more
> consistent form (I must be mad ...).
>
>
> Can I request that when you put _() strings in your code you
>
>     do not put spaces at the start or end of the string
>     do not put HTML tags in the string - break it up into pieces
>     do not put punctuation in the string - again, break it up into
> pieces
>     be consistent about case
>
>
> I've made a web page to help with translating (default on the left, your
> translation on the right) which I will send in when it looks a bit
> prettier :-)
>
>
> Catch y'all later ...
>
> Kitch
>
> On Fri, 2004-11-19 at 11:00 +1300, Phil Daintree wrote:
> > OK Kitch I got a lot of this in now - need to go back and do some double
> > checking though - Jesse just sent SpecialOrder.php which missed the cut -
> > its bed time here - can here knocking on the wall telling me to knock
> > off!!
> >
> > Checking in CreditStatus.php;
> > Checking in CustomerAllocations.php;
> > Checking in CustomerBranches.php;
> > Checking in DeliveryDetails.php;
> > Checking in DiscountCategories.php;
> > Checking in DiscountMatrix.php;
> > Checking in Logout.php;
> > Checking in SelectOrderItems.php;
> > Checking in ShipmentCosting.php;
> > Checking in Shipments.php;
> > Checking in Shippers.php;
> > Checking in Shipt_Select.php;
> > Checking in ShiptsList.php;
> > Checking in StockStatus.php;
> > Checking in SuppCreditGRNs.php;
> > Checking in SuppInvGLAnalysis.php;
> > Checking in SuppPaymentRun.php;
> > Checking in SuppShiptChgs.php;
> > Checking in SuppTransGLAnalysis.php;
> > Checking in SupplierAllocations.php;
> > Checking in SupplierContacts.php;
> > Checking in SupplierCredit.php;
> > Checking in SupplierInquiry.php;
> > Checking in SupplierInvoice.php;
> > Checking in Suppliers.php;
> >
> > quite a flourish to finish on.....
> >
> > and of course
> > Checking in locale/en/LC_MESSAGES/messages.po;
> >
> >
> > Worried about introducing bugs with such a lot at break neck speed.
> > I re-ran xgettext to update messages.po
> >
> >
> > An Italian chap contacted me spelling out duplications in the .po as it
> > was
> >
> > which may be useful:
> > > > I started translating web erp in italian, but realized that
> > > > messages.po in italian is not complete
> > > >
> > > > even *.po in english seem not perfect either:
> > > >
> > > > --------------------------------------------------------------------
> > > > bash-2.05b$ msgfmt *.po
> > > > msgfmt: index.po: warning: Charset "CHARSET" is not a portable
> > > > encoding name.
> > > >                            Message conversion to user's charset might
> > > > not work.
> > > > msgfmt: messages.po: warning: Charset "CHARSET" is not a portable
> > > > encoding name.
> > > >                               Message conversion to user's charset
> > > > might not work.
> > > > messages.po:7: duplicate message definition
> > > > index.po:8: ...this is the location of the first definition
> > > > messages.po:20: duplicate message definition
> > > > index.po:418: ...this is the location of the first definition
> > > > messages.po:844: duplicate message definition
> > > > index.po:414: ...this is the location of the first definition
> > > > messages.po:1165: duplicate message definition
> > > > index.po:293: ...this is the location of the first definition
> > > > messages.po:1800: duplicate message definition
> > > > index.po:29: ...this is the location of the first definition
> > > > messages.po:3793: duplicate message definition
> > > > index.po:410: ...this is the location of the first definition
> > > > messages.po:3849: duplicate message definition
> > > > index.po:378: ...this is the location of the first definition
> > > > messages.po:4087: duplicate message definition
> > > > index.po:390: ...this is the location of the first definition
> > > > messages.po:4410: duplicate message definition
> > > > index.po:209: ...this is the location of the first definition
> > > > messages.po:5518: duplicate message definition
> > > > index.po:149: ...this is the location of the first definition
> > > > messages.po:6958: duplicate message definition
> > > > index.po:189: ...this is the location of the first definition
> > > > messages.po:7683: duplicate message definition
> > > > index.po:153: ...this is the location of the first definition
> > > > messages.po:9314: duplicate message definition
> > > > index.po:21: ...this is the location of the first definition
> > > > messages.po:9326: duplicate message definition
> > > > index.po:257: ...this is the location of the first definition
> > > > messages.po:9368: duplicate message definition
> > > > index.po:265: ...this is the location of the first definition
> > > > messages.po:9641: duplicate message definition
> > > > index.po:25: ...this is the location of the first definition
> > > > messages.po:9649: duplicate message definition
> > > > index.po:33: ...this is the location of the first definition
> > > > messages.po:9653: duplicate message definition
> > > > index.po:37: ...this is the location of the first definition
> > > > messages.po:9657: duplicate message definition
> > > > index.po:41: ...this is the location of the first definition
> > > > messages.po:9661: duplicate message definition
> > > > msgfmt: too many errors, aborting
> > > > ---------------------------------------------------------------
> > > >
> > > > if you can provide a valid/updated messages.po I will happily
> > > > translate it in italian
> > > >
> > > > bye
> > > >
> > > > xlyz
> >
> > A few minor points men - I'm trying to use Jesse's prnMsg function
> > wherever possible - this does mean there is one common way for displaying
> > messages and we can muck about with the formats as we like - it is pretty
> > rudimentary but I like the idea of some kind of standardisation of
> > messages. Many echo statements can lose the <BR> and slot into a prnMsg
> > instead.
> >
> > I am probably slightly autistic in my zeal for having the code nicely
> > indented too - I tend to break after </TD> so the next line starts on a
> > <TD> HTML in CAPS ideally. SQL broken up field by field line breaks
> > before FROM. WHERE, AND, GROUP BY, ORDER BY
> >
> > All very picky stuff - dont bother if you dont want to I happy to have
> > the code anyway you like - but I try to modify it to comply with that
> > Contributing.txt doc before committing to CVS.
> >
> > WE DID IT!

-- 
Phil