Menu
▾
▴
Re: [Web-erp-developers] po tidy up
|
From: Steve K. <s.k...@bu...> - 2004-11-18 19:18:05
|
For me, the second option is better. Consider something like
'<BR>ERROR ! The code could not be found. Please re-enter the GL
reference'
and
'<BR>ERROR ! The code could not be found. Please re-enter the customer
code'
'ERROR' and 'The code could not be found' are common phrases that are
scattered throughout the application. When split up as suggested, only
one instance of the text 'ERROR' and the text 'The code could not be
found' are needed in the .po file.
Also, the current .po file is approaching 400K in size, so any
consolidation to reduce this should be considered A Good Thing (tm) :-)
Kitch
On Thu, 2004-11-18 at 14:03 -0500, Steve Kaill wrote:
> =EF=BB=BF=20
> Although I stuck to the majority of these recommendations I would have
> one question. What about punctuation within a string. e.g.
> =20
> '<BR> The code could not be found. Please verify and re-enter.'
> =20
> What about that period and space in the middle? Should it be
> =20
> '<BR> ' . _('The code could not be found. Please verify and
> re-enter') . '.'
> =20
> or
> =20
> '<BR> ' . _('The code could not be found') . '. ' . _('Please verify
> and re-enter') . '.'
> =20
> Steve
>=20
> ----- Original Message -----=20
> From: Steve Kitchen=20
> To: web...@li...=20
> Sent: Thursday, November 18, 2004 1:48 PM
> Subject: Re: [Web-erp-developers] po tidy up
> =20
> =20
> OK, I've had a look at all this stuff and here's the
> low-down ....
> =20
> =20
> As Phil says, things are somewhat messy with duplicate
> definitions, bits of puctuation, bits of HTML and the like in
> the text strings.
> =20
> I will go through all the existing modules and bash it into a
> more consistent form (I must be mad ...).
> =20
> =20
> Can I request that when you put _() strings in your code you=20
> =20
> do not put spaces at the start or end of the string
> do not put HTML tags in the string - break it up into
> pieces
> do not put punctuation in the string - again, break it up
> into pieces
> be consistent about case
> =20
> =20
> I've made a web page to help with translating (default on the
> left, your translation on the right) which I will send in when
> it looks a bit prettier :-)
> =20
> =20
> Catch y'all later ...
> =20
> Kitch
> =20
> On Fri, 2004-11-19 at 11:00 +1300, Phil Daintree wrote:=20
> =20
> > OK Kitch I got a lot of this in now - need to go back and do =
some double=20
> > checking though - Jesse just sent SpecialOrder.php which miss=
ed the cut - its=20
> > bed time here - can here knocking on the wall telling me to k=
nock off!!
> >=20
> > Checking in CreditStatus.php;
> > Checking in CustomerAllocations.php;
> > Checking in CustomerBranches.php;
> > Checking in DeliveryDetails.php;
> > Checking in DiscountCategories.php;
> > Checking in DiscountMatrix.php;
> > Checking in Logout.php;
> > Checking in SelectOrderItems.php;
> > Checking in ShipmentCosting.php;
> > Checking in Shipments.php;
> > Checking in Shippers.php;
> > Checking in Shipt_Select.php;
> > Checking in ShiptsList.php;
> > Checking in StockStatus.php;
> > Checking in SuppCreditGRNs.php;
> > Checking in SuppInvGLAnalysis.php;
> > Checking in SuppPaymentRun.php;
> > Checking in SuppShiptChgs.php;
> > Checking in SuppTransGLAnalysis.php;
> > Checking in SupplierAllocations.php;
> > Checking in SupplierContacts.php;
> > Checking in SupplierCredit.php;
> > Checking in SupplierInquiry.php;
> > Checking in SupplierInvoice.php;
> > Checking in Suppliers.php;
> >=20
> > quite a flourish to finish on.....
> >=20
> > and of course=20
> > Checking in locale/en/LC_MESSAGES/messages.po;
> >=20
> >=20
> > Worried about introducing bugs with such a lot at break neck =
speed.
> > I re-ran xgettext to update messages.po
> >=20
> >=20
> > An Italian chap contacted me spelling out duplications in the=
.po as it was=20
> > which may be useful:
> >=20
> > > > I started translating web erp in italian, but realized th=
at messages.po
> > > > in italian is not complete
> > > >
> > > > even *.po in english seem not perfect either:
> > > >
> > > > ---------------------------------------------------------=
-----------
> > > > bash-2.05b$ msgfmt *.po
> > > > msgfmt: index.po: warning: Charset "CHARSET" is not a por=
table encoding
> > > > name.
> > > > Message conversion to user's c=
harset might
> > > > not work.
> > > > msgfmt: messages.po: warning: Charset "CHARSET" is not a =
portable
> > > > encoding name.
> > > > Message conversion to user'=
s charset might
> > > > not work.
> > > > messages.po:7: duplicate message definition
> > > > index.po:8: ...this is the location of the first definiti=
on
> > > > messages.po:20: duplicate message definition
> > > > index.po:418: ...this is the location of the first defini=
tion
> > > > messages.po:844: duplicate message definition
> > > > index.po:414: ...this is the location of the first defini=
tion
> > > > messages.po:1165: duplicate message definition
> > > > index.po:293: ...this is the location of the first defini=
tion
> > > > messages.po:1800: duplicate message definition
> > > > index.po:29: ...this is the location of the first definit=
ion
> > > > messages.po:3793: duplicate message definition
> > > > index.po:410: ...this is the location of the first defini=
tion
> > > > messages.po:3849: duplicate message definition
> > > > index.po:378: ...this is the location of the first defini=
tion
> > > > messages.po:4087: duplicate message definition
> > > > index.po:390: ...this is the location of the first defini=
tion
> > > > messages.po:4410: duplicate message definition
> > > > index.po:209: ...this is the location of the first defini=
tion
> > > > messages.po:5518: duplicate message definition
> > > > index.po:149: ...this is the location of the first defini=
tion
> > > > messages.po:6958: duplicate message definition
> > > > index.po:189: ...this is the location of the first defini=
tion
> > > > messages.po:7683: duplicate message definition
> > > > index.po:153: ...this is the location of the first defini=
tion
> > > > messages.po:9314: duplicate message definition
> > > > index.po:21: ...this is the location of the first definit=
ion
> > > > messages.po:9326: duplicate message definition
> > > > index.po:257: ...this is the location of the first defini=
tion
> > > > messages.po:9368: duplicate message definition
> > > > index.po:265: ...this is the location of the first defini=
tion
> > > > messages.po:9641: duplicate message definition
> > > > index.po:25: ...this is the location of the first definit=
ion
> > > > messages.po:9649: duplicate message definition
> > > > index.po:33: ...this is the location of the first definit=
ion
> > > > messages.po:9653: duplicate message definition
> > > > index.po:37: ...this is the location of the first definit=
ion
> > > > messages.po:9657: duplicate message definition
> > > > index.po:41: ...this is the location of the first definit=
ion
> > > > messages.po:9661: duplicate message definition
> > > > msgfmt: too many errors, aborting
> > > > ---------------------------------------------------------=
------
> > > >
> > > > if you can provide a valid/updated messages.po I will hap=
pily translate
> > > > it in italian
> > > >
> > > > bye
> > > >
> > > > xlyz
> >=20
> >=20
> > A few minor points men - I'm trying to use Jesse's prnMsg fun=
ction wherever=20
> > possible - this does mean there is one common way for display=
ing messages and=20
> > we can muck about with the formats as we like - it is pretty =
rudimentary but=20
> > I like the idea of some kind of standardisation of messages. =
Many echo=20
> > statements can lose the <BR> and slot into a prnMsg instead.
> >=20
> > I am probably slightly autistic in my zeal for having the cod=
e nicely indented=20
> > too - I tend to break after </TD> so the next line starts on =
a <TD>
> > HTML in CAPS ideally. SQL broken up field by field line break=
s before FROM.=20
> > WHERE, AND, GROUP BY, ORDER BY
> >=20
> > All very picky stuff - dont bother if you dont want to I happ=
y to have the=20
> > code anyway you like - but I try to modify it to comply with =
that=20
> > Contributing.txt doc before committing to CVS.
> >=20
> > WE DID IT!
> >=20
|
