Re: [Web-erp-developers] Gettextification - Formatting

[skaill <sk...@ro...>]

This is a huge amount for those not as familiar with the code to get correct
in one shot.  I've been doing where I notice but I've also been using the
priorities

1) Don't mess anything up.
2) Translation is the main task and needs to be done quick and right.
3) The rest works right, it's cleanup.  Of course cleanup is good too.

With those priorities, at times, my blinders are on for the rest.  Just too
much.  Plus I don't even understand the differences between the old db
statements and these yet.  The rest I've been trying to do lately.

Steve

----- Original Message ----- 
From: "Phil Daintree" <we...@pa...>
To: <web...@li...>
Sent: Monday, October 11, 2004 5:11 PM
Subject: [Web-erp-developers] Gettextification - Formatting


> Just a small point on formatting  table echo statements:
>
> I had some pretty ugly looking echo statements I have been splitting them
with
> carriage returns after </TD> trying to keep a
>
> <TD>Some other stuff</TD>
>
> on a single line - so it is easier to see what is in each cell of a table.
>
> I have also been trying to tidy up with some carriage returns the printf
> statements and the SQL splitting up SQL on major constructs. The SELECT
> showing each column returned on a separate line, then the FROM showing
each
> table being used on a separate line, then the WHERE with each AND split
also.
> I think the resultant SQL is quite a bit more readable.
>
> As with a few things I wish I had done this from the outset but hey!!!
>
> Also, I am still trying to make all calls to DB_query use $ErrMsg and
$DbgMsg
> and occassionally rollback=true
>
> DB_query takes up to 5 parameters
>
> $result = DB_query(
> $SQL ,
> $TheDBHandle,
> $ErrorMessageOnFail,
> $DebugMessageOnlyVisibleToASysAdmin,
> $InTheMiddleOfADBTransationSoRollbackIfError,
> $DontHandleErrorsInsideThisFunction
> );
>
> $DebugMessageOnlyVisibleToASysAdmin defaults to
>
> _('the SQL that failed was') - or something like it.
>
> $InTheMiddleOfADBTransationSoRollbackIfError - defaults to false so no
> rollback is attempted if an error is returned from the SQL server
>
> $DontHandleErrorsInsideThisFunction defaults to false - so DB_query always
> tries to handle errors if not set to true - this is a problem in that
> attempts to check for errors after calls to DB_query will not even be
> actioned - since DB_query will have included footer.inc and exited the
> script!
>
>
> Phil
>
>
> On Sunday 10 October 2004 22:16, skaill wrote:
> > Here's Payments.php including diff...
> >
> > Steve
> >
> > ----- Original Message -----
> > From: "Phil Daintree" <we...@pa...>
> > To: <web...@li...>
> > Sent: Sunday, October 10, 2004 1:08 AM
> > Subject: [Web-erp-developers] Gettextification new scripts Steve
> >
> > > OK Steve,
> > >
> > > I already pushed it too hard with the Company Preferences one!
> Phil
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out
more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers