[Web-erp-developers] Gettextification - Formatting

[Phil D. <we...@pa...>]

Just a small point on formatting  table echo statements:

I had some pretty ugly looking echo statements I have been splitting them with 
carriage returns after </TD> trying to keep a

<TD>Some other stuff</TD>

on a single line - so it is easier to see what is in each cell of a table.

I have also been trying to tidy up with some carriage returns the printf 
statements and the SQL splitting up SQL on major constructs. The SELECT 
showing each column returned on a separate line, then the FROM showing each 
table being used on a separate line, then the WHERE with each AND split also. 
I think the resultant SQL is quite a bit more readable. 

As with a few things I wish I had done this from the outset but hey!!!

Also, I am still trying to make all calls to DB_query use $ErrMsg and $DbgMsg 
and occassionally rollback=true 

DB_query takes up to 5 parameters

$result = DB_query(
					$SQL , 
					$TheDBHandle, 
					$ErrorMessageOnFail, 
					$DebugMessageOnlyVisibleToASysAdmin,
					$InTheMiddleOfADBTransationSoRollbackIfError,
					$DontHandleErrorsInsideThisFunction
				);

$DebugMessageOnlyVisibleToASysAdmin defaults to

_('the SQL that failed was') - or something like it.

$InTheMiddleOfADBTransationSoRollbackIfError - defaults to false so no 
rollback is attempted if an error is returned from the SQL server

$DontHandleErrorsInsideThisFunction defaults to false - so DB_query always 
tries to handle errors if not set to true - this is a problem in that 
attempts to check for errors after calls to DB_query will not even be 
actioned - since DB_query will have included footer.inc and exited the 
script!


Phil


On Sunday 10 October 2004 22:16, skaill wrote:
> Here's Payments.php including diff...
>
> Steve
>
> ----- Original Message -----
> From: "Phil Daintree" <we...@pa...>
> To: <web...@li...>
> Sent: Sunday, October 10, 2004 1:08 AM
> Subject: [Web-erp-developers] Gettextification new scripts Steve
>
> > OK Steve,
> >
> > I already pushed it too hard with the Company Preferences one!
Phil