From: Phil D. <we...@pa...> - 2004-09-19 08:35:26
|
Jesse, I have committed a whole lot of this but am still concerned about bugs creeping in. I hate testing but there is no alternative really to keep the quality up. Sorry its taken me so long to figure it out - it took me quite a while to go through it all so goodness knows how long this took you to do. I can see that there is some reduction on some scripts and a couple of new includes. It seems fairly straightforward - he said after some time figuring it all out again - although I see your class idea (and yes, I know you started down this track to start with) has some merit. However, I am not keen to re-invent a wheel which appear roughly round already. There is a massive amount of work here that you have contributed - many thanks. I did notice Credit_Invoice.php doesn't add up the batches/serial numbers retrieved from the invoice it is crediting - although if you go into the controlled page she then recalculates ok. I haven't looked into this yet - you may know the answer. There a fair bit of gettextification done now too. My count says 27 scripts - and most of the real nasties are done. I have to say I am a little dissappointed that the foreign language speakers are not as involved in this as I had hoped. Thanks to everyone who has chipped in so far - hope you guys have the stamina to keep 'em coming. I will try to release a new file later on - there is a fair bit changed now since 2.9 Phil |