Re: [Web-erp-developers] Re: Converted Customers.php for multi-language support

[Phil D. <we...@pa...>]

Fantastic!

There is only one tiny issue .... calls to the DB_query function like
the following:

	$CustomerResult = DB_query($SQL,$db);

	if (DB_error_no($db) !=0) {
		echo _('The customer details could not be retrieved by the SQL
because') . ' - ' . DB_error_msg($db);

		if ($debug==1){
			echo '<BR>' . $SQL;
		}
		exit;
	}

becomes:

$ErrMsg = _('The customer details could not be retrieved because');
$DbgMsg = _('The SQL that failed was');
$CustomerResult = DB_query($SQL,$db,$ErrMsg, $DbgMsg);

This was a change made by Jesse to the DB_query function to avoid all
the repetition of the first lot of code.

I have changed them all over now.

Thanks for all your help and I am bound to ask (I am now pushing it a
bit) ... would you do a few more?


DiscountCategories.php
DiscountMatrix.php

Phil


On Tue, 2004-09-07 at 17:41, Victor wrote:
> Hi Phil,
> 
> Yesterday, I could only finish the conversion of CustomerReceipt.php
> Today, I also finish the other script CustomerTransInquiry.php
> Please check them and let me know whether there is any error.
> Thanks!
> 
> Victor
> 
> ----- Original Message ----- 
> From: "Phil Daintree" <we...@pa...>
> To: "Victor" <vi...@hi...>;
> <web...@li...>
> Sent: Saturday, September 04, 2004 1:30 PM
> Subject: Re: Converted Customers.php for multi-language support
> 
> 
> > Perfect!
> > I notice you have even changed to single ' to improve performance!
> >
> > I have committed this to the CVS.
> >
> > Many thanks!
> >
> > Could I impose on you for a few more scripts?
> >
> > CustomerReceipt.php
> > CustomerTransInquiry.php
> >
> > Thanks
> >
> > Phil
> >
> > On Sat, 2004-09-04 at 01:02, Victor wrote:
> > > Hi Phil,
> > >
> > > It seems that Customers.php is not a difficult script to be converted
> > > for multi-language support.
> > > Therefore I have made the conversion. Please take a look and let me
> > > know whether there is any mistake.
> > >
> > > Regards,
> > > Victor
> >