From: Phil D. <we...@pa...> - 2004-08-29 04:49:09
|
Steve, Many hearty thanks for your latest contributions - it feels absolutely great not to be on my own with this anymore! I included the lot of it with just a couple of mods. I put language in the user settings script and made it look up the available directories for theme and language rather than hard coding them. As discussed I didn't see the requirement for the enable javascript option - this may be my understanding - and I was not keen on the small / two storey quick links. I used the user name as the link to user settings. The scripts that didnt display properly I resolved by including footer.inc and removing the </body></html> from these. I changed references to mysql specific functions to the DB abstraction functions DB_data_seek in ConnectDB.inc. I set $_POST['PageOffset'] = 1; where there was a new search - an error was returned where the previous page offset was too big for a smaller recordset returned with a new search. Got into trouble with SelectProduct.php a bit you may want to have another look but I couldnt get it to select an item. I eventually got it working somewhat but its a bit of a hack with a check to make sure the pageoffset is beyond the max - this caused an error if ($_POST['PageOffset']>$ListPageMax){ $_POST['PageOffset'] = $ListPageMax; } Also the hidden $_POST['Search'] I removed in favour of checking Go, Next and Previous. I also tried to encapsulate all the strings in _("string") for multi-language. I do like the diff file to work through what was actually changed it saves a massive amount of work really - so thanks for making it so easy! If you'd like to, please do add some comment about your contributions in a comment at the start of the script. Phil > A bit of java for the help may be very useful. It is a real pain and > confusing for many users to have the help appear full screen in > browser. Here's some code for Help.php that would do it if you > want... > > <?php > /* $Revision: 1.5 $ */ > > if (isset($_GET['Title'])){ > $HelpPageTitle = $_GET['Title']; > }elseif(isset($_POST['HelpPageTitle'])){ > $HelpPageTitle = $_POST['HelpPageTitle']; > } > > $title = "Help On " . $HelpPageTitle; > > $PageSecurity = 1; > > include("includes/session.inc"); > include("includes/header.inc"); > include('includes/htmlMimeMail.php'); > ?> > > <script language="JavaScript" type="text/javascript"> > <!-- > // resize window > window.resizeTo(900,500); > window.moveTo(15,200); > //--> > </script> > > <?php > if (isset($_GET['Page'])){ > $Page = $_GET['Page']; > } elseif (isset($_POST['Page'])){ > $Page = $_POST['Page']; > } > ... > > Steve > > |