Re: [Web-erp-developers] Credit Items & Controlled Items

[Daintree <p.d...@pa...>]

> I'm down to finishing up my Serialised Item work and just need to get the
Credit_invoice and SelectCreditItems finalized. I've realized that currently
one seems to be allowed to Credit back items which were never purchased -
this does not seem right. In validating Serialised Items, I've made sure
they exist and can be used (ie, you can't sell an item you've already
sold... unless it has been returned to stock, like through a Credit). I
planned to also validate Serialised items returned on a CreditNote - must
exist, must have been sold to the Customer being credited, and must still be
attached to a SalesOrder.
> Thoughts on that? I'd be inclined to simply not allow Credits for more
Items than have been purchased.


Its a good point, I can see an argument both ways. The arguments against I
see are:
When a customer's account and stock movements are purged two years later -
the warranty is 5 years ....
When a customer makes a product which has wider appeal and you wish to
market it, it would be great to be able to book it in as a credit note
knocking off against what he owes us.


>
> In tracking Controlled Items I force a BundleId to be entered for the
goods as they are Received via a PO and as they sold via a SO. One
consideration, which I believe will be made/changed in a second round on
Serialised additions is forcing unique BundleIds (ie, auto selecting them
through a new method rather than prompting the User to enter them). What I
am wondering is the best way to track Credited, Controlled Items coming back
in. I have a feeling that they should be tracked using the BundleId they
went out on a SO with.
>
> If that is the case, I now also need to force a Bundle to be selected when
Controlled Items are to be credited, which again requires that only items
that have been sold can be Credited.

There are two credit note scripts one is to credit an invoice - the details
of the invoice can be retrieved with serial numbered items as they were when
invoiced. I still think there needs to be scope to change these though, in
case the customer returns other than the originally invoiced items or a
mistake was made when invoicing/pciking the right items.

The other credit note SelectCreditItems.php should allow free form entry of
the bundleIDs .... I rekon.


That brings some changes since it is not as easy to return 5 (each) of 10
different StockIds from 3 different Bundles. Further, when using
SelectCreditItems, I'll need to create StockMoves for every affected Bundle.
Using Credit_Invoice this is taken care of since it is restricted to one
Invoice, thus 1 LineItem per StockId, so also just 1 BundleId.
>
> So, I guess the question is just whether you should be able to Credit
items that were never sold....
>

I vote yes.

Phil