From: Phil D. <ph...@du...> - 2004-02-26 00:51:59
|
Thanks very much Dick, I will include it tonight and try for a release too. Gosh you have a thousand ideas .... all gratefully received.I will do some more research on these. I am aware of PEAR - the most popular module being the db abstration layer. However, there is really quite a performance penalty in using it so I avoided it deliberately. I have an uneducated preference for including class files like we have for pdf.php -the R & OS pdf class and htmlMimeMail.php class for sending email attachments where we can make it simple for installation and administration. With respect to include files called .inc you are right. We should try to change these over time to .php. With repect to functions used in other scripts, i agree we should keep these available in a seperate script to be included with each script that needs them. The script SQL_CommonFunctions.inc is for this purpose. However, I have the view that functions that are only ever used by the one script can be left in that script. Phil ----- Original Message ----- From: "Stins, D.R." <d.r...@wo...> To: <ph...@du...> Sent: Thursday, February 26, 2004 12:05 PM Subject: Re: TaxAuthLevels > Phil, > > I prefer to finish it by myself, but you are in a hurry and I do not have > enough time left. I was delayed by the flue. So be my guest. > > I think that the attached scripts runs fine. > > I hoped to make it compatible with the current frontend. Like you said, I > was struggling understanding a bad example. I hope my proposal is simple and > easy to understand. > > I splitted the database functions from the frontend script. We get then a > better readable frontend script and we can reuse the database functions in > other scripts and it is easier to port to other database engines, since all > database engine related functions are in "one" include file. Later I might > consider to generate these very basic functions from the datamodel for every > table. > > I do not like the .inc suffix, since people can download the php code with > the .inc suffix at most servers. > That's why I used the Inc prefix. > > I think we should stop support for disabled foreign keys, but release 2.8 is > probably too early for that. So you to upgrade the taxauthority.php script > for release 2.8. > > We should consider use classes. See for a introduction: > http://www.webreference.com/programming/phpanth2/ > > Since we have future plans for CRM, I think we should consider the horde > application framework. I mgiht also speedup new developments. > > See www.horde.org and http://dev.horde.org/api/horde/. I think it is a very > good example for use of classes. Horde uses also PEAR: http://pear.php.net/ > > The documentation is created with http://www.phpdoc.org > > Maybe a good idea to use this documentation concept also for web-erp. > > With best regards, > > Dick Stins > > ----- Original Message ----- > From: "Phil Daintree" <ph...@du...> > To: <DR...@Zi...> > Sent: Wednesday, February 25, 2004 9:57 AM > Subject: TaxAuthLevels > > > > Dick, > > > > I guess you are struggling here with this. If you send me what you have I > will > > finish it off. Alternatively if you would prefer me to write it, please > let > > me know. > > > > Since there is a bug in 2.7 I am very keen to get 2.8 out. > > > > Sorry to push. > > > > Thanks for your help. > > Phil > > > |