[Web-erp-developers] Re: Code as promised...

[Phil D. <ph...@du...>]

Shane,

This is brilliant - it really lifts the system graphically - there is a fair 
amount of work in there too clearly you have put in a couple of hours to get 
it to this point!

It actually makes more room for the data by reducing the size of the header 
and moving the copyright stuff down in the footer where it probably belongs. 
I guess I was minimising the work for the parser by reducing the number of 
includes. (he said trying to make excuses for the woeful appearance of the 
old version by comparison!)

I did like the company logo on the screen - though the point is well made it 
was too heavy on real estate. The logo.jpg is still required on reports - 
inovices statements etc. I am not sure where the logo.jpg should live - 
wouldn't want it to depend on the theme so perhaps leave it in the root 
directory ??

I am amazed at what you have done with a minimal amount of additional 
graphics.

Is the images directory meant to replace the part_pics directory ?? But you 
still refer to the part_pics directory in the config.php also have the images 
under the theme directory under css. I see the css/theme/images directory 
purpose but am a little confused on what the /images directory is for.

I notice the icons are microsoft ones - I'd be keen to avoid these...
I also thought the use of .gifs was a problem - we certainly don't want any 
legal trouble. In the meantime I changed the icons to open source ones - I am 
completely relaxed about which ones are used except anything that lands a 
lawsuit on me should be avoided :-)

Some structure to the files is appropriate, now there are getting to be quite 
a number of scripts. I was a fan of putting the whole lot in the same 
directory so the newbie developer doesn't have to hunt down the file he's 
after. However, the directory includes should give the game away adequetly I 
think! 

There are a number of other files that probably belong under the includes 
directrory ie they are never called on their own but from some other script.
 config.php ? 
class.pdf.php
RFC822.php
htmlMimeMail.php
mimePart.php
smtp.php
DefineCartClass.php
DefineJournalClass.php
DefinePaymentClass.php
DefinePOClass.php
DefineReceiptClass.php
DefineSuppAllocClass.php
DefineCustAllocsClass.php
DefineSuppTransClass.php
FailedLogin.php
Login.php
Logout.php


I have no problem with renaming the header.inc - session.inc and 
HeaderTitle.inc header.inc except for the work in doing so and in modifying 
all the files that refer to them !! it does make more sense the way you have 
it.


I LOVE the WebERP+ logo!


I have found a few bugs and will work through them:

On some pages the footer appears at the top left of the page over the titles - 
supplierallocations.php I didn't look into why but it'll be simple to fix I'm 
sure.

The SelectItems.php table of options - that comes up when an item is selected 
- is missing some headings - again a simple one I guess.

Clearly, I have seriously neglected the visuals on the system to date and your 
input here looks as though its going to be fantastic. My focus has always 
been on the function with my asthetic sense whilst not offended clearly not 
well developed. It's really good to have some input here to complement my 
shortcomings!

I think I have brought in all of your code now and I have re-applied the 
latest bug fixes I have done.

Many thanks for this substantial contribution.

Phil

On Saturday 30 August 2003 07:00, you wrote:
> Phil Daintree,
>
> As mentioned in my last email, attached is a zip file of the code.
>
> Shane Barnaby
> Web Administrator
> Alco Ventures Inc.
> sba...@al... <mailto:sba...@al...>
> www.alcoventures.com <http://www.alcoventures.com/>
> tell: 604.513.2527
> fax: 604.513.2528