Re: [WebERP-developers] Performance issue in Payments.php

[Pak R. <pak...@gm...>]

Many thanks Phil.

My bad, I did not know the change to github. Could you please send me the
relevant info of the repository, so I check it out directly?.


Regards,
Ricard

On 12 March 2018 at 15:30, Phil Daintree <ph...@lo...> wrote:

> Hi Ricard,
>
> Good to hear you are still getting good mileage from webERP
>
> I can't see this SQL in Payments.php now ....
>
> We just recently moved the code to git at github.com due to ongoing
> issues with subversion at sourceforge.
>
> I looked at the history of Payments.php and it looks like Exson changed it
> in July 2017 to look for cheque numbers in supptrans rather than gltrans
>
> https://github.com/webERP-team/webERP/commit/bad8aea522d5e1a
> 2b777999c703b56c5d9441b6c#diff-179bc0f696b3eea3fb4764ee514a6e6a
>
> Phil
>
> Phil Daintree
> +64 (0)275 567890
>
>
> On 12/03/18 14:01, Pak Ricard wrote:
>
>> Hi:
>>
>> Since some months ago, Payments.php goes very slow (some 15-20 seconds)
>> each time a user hit submit with a new GL Analysis line into the payment.
>>
>> If I am not wrong code starts at line 718 until line 782
>>
>> Line 720 is a query against gltrans. This query alone needs around 15-18
>> seconds, which points it as the main cause of the problem here.
>>
>> gltrans has some 5M rows, and we do not use cheque, so gltrans.chequeno =
>> 0
>> for all the rows
>> gltrans index by chequeno is setup
>>
>> If I modify line
>> $ChequeNoSQL="SELECT account FROM gltrans WHERE chequeno='" .
>> $_POST['Cheque'] ."'";
>> to
>> $ChequeNoSQL="SELECT account FROM gltrans WHERE chequeno='" .
>> $_POST['Cheque'] ."' LIMIT 1";
>>
>> the issue is fixed (instant execution).
>>
>> Payments.php only checks twice if the query got any result, but never read
>> the account returned, so should be no collateral damage.
>>
>> I can't commit to SVN as I changed laptop and could not set it up yet.
>> Could someone please commit it?
>>
>> Regards,
>> Ricard
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Web-erp-developers mailing list
>> Web...@li...
>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>