From: Rafael C. <raf...@gm...> - 2017-05-17 04:23:02
|
Hi, Thanks Tim. Because I like small devices, I am a little bit fanatic of "Low footprint" Principle. Yes, this solution makes the code clearer. So, I think, in this case, "Easily readable code" Principle should be over the "Low footprint" Principle, and we got the desired result. Note: in this solution, traffic is the same in all cases (on/off ShowFieldHelp). If no more comments, I will work on implementing this solution. Best regards, Rafael. ---------- Forwarded message ---------- From: Tim Schofield <tim...@gm...> Date: 2017-05-16 7:50 GMT-06:00 Subject: Re: [WebERP-developers] Fwd: [Web-erp-svn] SF.net SVN: web-erp:[7751] trunk To: Rafael Emilio Chacon <raf...@gm...> Cc: Phil Daintree <ph...@lo...>, ExsonQu <hex...@gm...> Hi Rafael, I have implemented the help text in css. As you have said this increases traffic, but as it is just plain text this will never amount to more than a few hundred bytes, and most often less than that. It does have the benefit of taking out the conditional statements making the code clearer (IMHO). You can see what I have done at https://demo.kwamoja.org (the only script with field help in it at the moment is UserSettings.php) and all the code is at https://github.com/timschofield/KwaMoja/commit/ 353869b4c6e4b00626dc54f07fc52590ecc025fd Let me know what you think, Tim On 4 May 2017 at 16:35, Rafael Chacón <raf...@gm...> wrote: > Hi, > > Sorry for the delay. > > For security reasons (see > http://stackoverflow.com/questions/7129842/what-is-inc-and-why-to-use-it ), > it is recommend to use ".inc.php" or ".php". Also, for standartisation, it > is better to use a general *.php extension. > > Like reduce texts to translate (e.g. "Yes", "Yes!" and "yes" to "Yes"); > simplify and clean-up code and formats, update images, etc., I do this on > hollydays. > > About the options ShowPageHelp and ShowFieldHelp: This is to reduce info to > display. Exson and his team begun to work with webERP in small devices; we > tested without css (none.css), and it seems possible to operate webERP in > small devices. One way to do not have additional statements for every field > is to use a general style for ShowFieldHelp and JavaScript to exchange > between both states (display/hide), but always the help text will be sent > (more traffic). I would like suggestions in this topic. > > Best regards, Rafael. > > 2017-04-18 14:14 GMT-06:00 <ph...@lo...>: > >> Well the php extension is never rendered - but an inc file is viewable >> as text in most browsers - not really ideal and better to have it as a >> .php file I think. >> I am a bit worried about the FieldHelp config option as I would not like >> additional if statements throughout for every field. >> >> Phil >> >> On 2017-04-18 06:27, ExsonQu wrote: >> > *Hi, Rafaell,* >> > >> > Does this really make sense? >> > >> > Best regards! >> > >> > Exson >> > >> > >> > >> > >> > >> >> ------------------------------------------------------------ >> ------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Web-erp-developers mailing list >> Web...@li... >> https://lists.sourceforge.net/lists/listinfo/web-erp-developers >> > ------------------------------------------------------------ ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Web-erp-developers mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/web-erp-developers -- Course View Towers, Plot 21 Yusuf Lule Road, Kampala T +256 (0) 312 314 418 M +256 (0) 752 963 325 www.weberpafrica.com Twitter: @TimSchofield2 Blog: http://weberpafrica.blogspot.co.uk/ |