Re: [WebERP-developers] Replace addJpegFromFile() [from R&OS pdf.php] with Image() [from tcpdf.php].

[Rafael C. <raf...@gm...>]

Hi Tim,

I was not thinking in keep class.pdf.php as a wrapper class. I was thinking
on simplify code and make it more efficient, fast, and readable. The
resources saved on using the native TCPDF functions directly can be
invested in new functionalities (and to move to a new form editor).

I explain myself: we can have more options so that customization is done
inside an xml file rather than directly on the php code. I hope that will
reduce the merge work of upgrades to the custom versions.

I am working on: Set alpha to semi-transparency images; use of several
image types rather than jpeg; turn-no/turn-off additional elements; round
or not each corner of a rectangle;  turn-no/turn-off a rectangle
border; colour fill of a rectangle; style of a line (several types of
dots); include Ellipses, regular-polygons and star-polygons; use of soft
hyphen ("shy" character), etc.

I think it's best to get as close as possible to html code.

Best regards, Rafael.


2016-10-03 7:09 GMT-06:00 Tim Schofield <tim...@gm...>:

> Hi Rafael,
>
> As I understand it by retaining class.pdf.php as a wrapper class we
> keep the option of changing from TCPDF at some point in the future. In
> that case all we would have to do is to change the one class rather
> than having to change all the files that use PDF functionality.
>
> Or am I missing something?
>
> Thanks
> Tim
>
> On 1 October 2016 at 19:26, Rafael Chacón
> <raf...@gm...> wrote:
> > Hello,
> >
> > As way to simplify code and make it more efficient, fast, and readable,
> we
> > are looking to do not have includes/class.pdf.php and used the native
> TCPDF
> > functions directly.
> >
> > One step is to Replace addJpegFromFile() [from R&OS pdf.php] with Image()
> > [from tcpdf.php].
> >
> > Change to be done:
> > // Company Logo:
> > /*$pdf->addJpegFromFile($_SESSION['LogoFile'], $XXX, $YYY, $WWW,
> $HHH);*/
> > $pdf->Image(
> > $_SESSION['LogoFile'],// Name of the file containing the image.
> > $XXX,// Abscissa from left border to the upper-left corner (LTR).
> > $Page_Height -($YYY) -($HHH),// Ordinate from top border to the
> upper-left
> > corner (LTR).
> > $WWW,// Width of the image in the page. If not specified or equal to
> zero,
> > it is automatically calculated.
> > $HHH,// Height of the image in the page. If not specified or equal to
> zero,
> > it is automatically calculated.
> > ''// Image format. If not specified, the type is inferred from the file
> > extension.
> > );// Public function Image() in ~/includes/tcpdf/tcpdf.php
> >
> > That change needs to done in 35 files:
> > ~/FixedAssetRegister.php
> > ~/PDFFGLabel.php
> > ~/PDFGLJournalCN.php
> > ~/PDFPrintLabel.php
> > ~/PDFQALabel.php
> > ~/PDFReceipt.php
> > ~/PDFRemittanceAdvice.php
> > ~/PrintCustTrans.php
> > ~/PrintCustTransPortrait.php
> > ~/includes/PDFBankingSummaryPageHeader.inc
> > ~/includes/PDFChequeListingPageHeader.inc
> > ~/includes/PDFCOAHeader.inc
> > ~/includes/PDFCustTransListingPageHeader.inc
> > ~/includes/PDFDeliveryDifferencesPageHeader.inc
> > ~/includes/PDFDIFOTPageHeader.inc
> > ~/includes/PDFGLJournalHeaderCN.inc
> > ~/includes/PDFGLJournalHeader.inc
> > ~/includes/PDFGrnHeader.inc
> > ~/includes/PDFOrderPageHeader_generic.inc
> > ~/includes/PDFOrdersInvoicedPageHeader.inc
> > ~/includes/PDFOrderStatusPageHeader.inc
> > ~/includes/PDFPeriodStockTransListingPageHeader.inc
> > ~/includes/PDFPickingListHeader.inc
> > ~/includes/PDFProdSpecHeader.inc
> > ~/includes/PDFQuotationPageHeader.inc
> > ~/includes/PDFQuotationPortraitPageHeader.inc
> > ~/includes/PDFSalesOrder_generic.inc
> > ~/includes/PDFStatementPageHeader.inc
> > ~/includes/PDFStockTransferHeader.inc
> > ~/includes/PDFSuppTransListingPageHeader.inc
> > ~/includes/PDFTopItemsHeader.inc
> > ~/includes/PDFTransPageHeader.inc
> > ~/includes/PDFTransPageHeaderPortrait.inc
> > ~/includes/PDFWOPageHeader.inc
> > ~/includes/PO_PDFOrderPageHeader.inc
> >
> > I afraid that some of these files are used with customisation. If that is
> > true, please let me know which files are customised, to take the
> appropriate
> > precautions.
> >
> > Best regards, Rafael.
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Web-erp-developers mailing list
> > Web...@li...
> > https://lists.sourceforge.net/lists/listinfo/web-erp-developers
> >
>
>
>
> --
> Course View Towers,
> Plot 21 Yusuf Lule Road,
> Kampala
> T   +256 (0) 312 314 418
> M +256 (0) 752 963 325
> www.weberpafrica.com
> Twitter: @TimSchofield2
> Blog: http://weberpafrica.blogspot.co.uk/
>