Re: [WebERP-developers] TableRows()

[Phil D. <ph...@lo...>]

Ricard,

There are many many ways to reduce the amount of code in webERP - we 
really could take loads out... but the sacrifice is readability - I 
don't believe we would gain speed/efficiency.
If we made the tables a class as per Jonathan's idea we could take out 
buckets of code - this would be the obvious extension of the
I don't want to change the code to increase abstraction ever - or code 
that does the same thing a different way that could potentially 
introduce new bugs. Nope - the effort should be not to reinvent what we 
have, but to add functionality using the same blocks and structure as we 
have.

I believe you learnt php from webERP - and are a living example as to 
why the phil-osophy behind webERP's development style is one of it's 
greatest strengths...

Phil

Phil Daintree
Logic Works Ltd - +64 (0)275 567890
http://www.logicworks.co.nz

On 02/09/14 13:12, Pak Ricard wrote:
> Hi Phil:
>
> I saw with satisfaction the commit 6859 where Rafael used the 
> TableRows() functions in some scripts. Now, I saw this change was 
> reverted, and I can't see but good things about it (probably i'm 
> missing something).
>
> These same 6 lines are repeated over and over webERP (probably over 
> 100 times), so if we get a change to reduce the number of lines and 
> still get a readable script, I think it's worth it.
>
> Well just my 2 cents. I would love to know your POV (and any other 
> developer's) about it :-)
>
> Regards,
> Ricard
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
>
>
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers