Re: [WebERP-developers] Problems in Tx rollback at CounterSales.php

[webERP D. <web...@li...>]

Hi Phil:

I did the following test (probably you can replicate it then):
- Substitute line 1794 of CounterSales.php by:
'" . "IT_IS_NOT_AN_ACCOUNT_CODE" . "',
 so we are sure this SQL will fail.

- if it fails it should rollback until the DB_tx_Begin() but on my DB I
still can find the associated rows on tables:
salesorders
salesorderdetails (N rows)

but debtortrans, locstock, stockmoves, gltrans are properly rollbacked.

So the problem seems to be related to those 2 tables salesorders and
salesordersdetails.

Even at audit trail, the records related to salesorders and
salesordersdetails are still available to check (further confirmation that
have not been rollbacked).

Regards,
Ricard


2013/5/18 webERP Developers <web...@li...>

>
> I can see the db_query() call for inserting the  order header did not have
> the format:
>
> DB_query($SQL,$db,$ErrMsg,$DbgMsg,true);
>
> which it should be to rollback on encountering an error.
>
> However, this is not on a gl entry which it sounds like your entry failed
> on.
>
> Phil
>
> Phil Daintree
> Logic Works Ltd - +64 (0)275 567890http://www.logicworks.co.nz
> skype:daintree
>
>
> On 18/05/13 13:25, webERP Developers wrote:
>
> Hi Phil:
>
>  All my tables are innodb except those of mrp and the wiki ones (I think
> I'm using the default).
>
>  Other scripts that caused errors (as SupplierInvoice,
> InternalStockRequestFulfill) seem to do the rollback OK, so I guess it is
> something on the CounterSales.php or a DB setting.
>
>
>  Regards,
> Ricard
>
>
> 2013/5/18 webERP Developers <web...@li...>
>
>>  Sounds silly - but I have come accross some installations using myisam
>> tables not innodb - I suspect this is not the issue but just in case - can
>> you please confirm.
>>
>> Thanks
>>
>> Phil
>>
>> Phil Daintree
>> Logic Works Ltd - +64 (0)275 567890http://www.logicworks.co.nz
>> skype:daintree
>>
>>
>> On 18/05/13 11:53, webERP Developers wrote:
>>
>>  Hi all:
>>
>>  Due to a wrong change in GL account code to varchar(20) (now fixed and
>> committed) I was facing some errors at CounterSales.php
>>
>>  Big problem was, it is not performing the rollback properly.
>>
>>  At some point the script tried to update a GL account that did not
>> exist, and wisely the system stopped and showed a database error 1452:
>> cannot add or update a child row....
>>
>>  So, the script is supposed to rollback until the DB_tx_Begin, but it
>> did not and DB was left inconsistent.
>>
>>  Checked and added more error reporting and rollback seems succesful but
>> it is not.
>>
>>  As example, the INSERT into salesorders and INTO salesorderdetails are
>> left at the DB, even if some INSERT at gltrans failed.
>>
>>  Could not fix it yet. Anyone faced the same problem?
>>
>>
>> Regards,
>> Ricard
>>
>>
>>  ------------------------------------------------------------------------------
>> AlienVault Unified Security Management (USM) platform delivers complete
>> security visibility with the essential security capabilities. Easily and
>> efficiently configure, manage, and operate all of your security controls
>> from a single console and one unified framework. Download a free trial.http://p.sf.net/sfu/alienvault_d2d
>>
>>
>>
>> _______________________________________________
>> Web-erp-developers mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>
>>
>>
>> ------------------------------------------------------------------------------
>> AlienVault Unified Security Management (USM) platform delivers complete
>> security visibility with the essential security capabilities. Easily and
>> efficiently configure, manage, and operate all of your security controls
>> from a single console and one unified framework. Download a free trial.
>> http://p.sf.net/sfu/alienvault_d2d
>> _______________________________________________
>> Web-erp-developers mailing list
>> Web...@li...
>> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>>
>>
>
>
> ------------------------------------------------------------------------------
> AlienVault Unified Security Management (USM) platform delivers complete
> security visibility with the essential security capabilities. Easily and
> efficiently configure, manage, and operate all of your security controls
> from a single console and one unified framework. Download a free trial.http://p.sf.net/sfu/alienvault_d2d
>
>
>
> _______________________________________________
> Web-erp-developers mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>
>
>
> ------------------------------------------------------------------------------
> AlienVault Unified Security Management (USM) platform delivers complete
> security visibility with the essential security capabilities. Easily and
> efficiently configure, manage, and operate all of your security controls
> from a single console and one unified framework. Download a free trial.
> http://p.sf.net/sfu/alienvault_d2d
> _______________________________________________
> Web-erp-developers mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>
>