[Weberp-cvs] SF.net SVN: web-erp:[3535] trunk

[<dai...@us...>]

Revision: 3535
          http://web-erp.svn.sourceforge.net/web-erp/?rev=3535&view=rev
Author:   daintree
Date:     2010-06-30 09:26:50 +0000 (Wed, 30 Jun 2010)

Log Message:
-----------
Resolution of GL posting problem - removed INSERTs of new chartdetails from DateFunctions.inc CreatePeriod function and GLAccounts.php when adding a new GL account. Now all chartdetails are created from includes/GLPostings.inc and correct bfwd balances updated as they should be - I hope this solves this long outstanding previously unsquashable bug!!

Modified Paths:
--------------
    trunk/GLAccounts.php
    trunk/doc/Change.log.html
    trunk/includes/DateFunctions.inc

Modified: trunk/GLAccounts.php
===================================================================
--- trunk/GLAccounts.php	2010-06-29 13:24:19 UTC (rev 3534)
+++ trunk/GLAccounts.php	2010-06-30 09:26:50 UTC (rev 3535)
@@ -55,7 +55,7 @@
 		$result = DB_query($sql,$db,$ErrMsg);
 
 		/*Add the new chart details records for existing periods first */
-
+/*Maybe not required since these will be created from GLPostings.inc with correct B/fwd balances
 		$ErrMsg = _('Could not add the chart details for the new account');
 
 		$sql = 'INSERT INTO chartdetails (accountcode, period)
@@ -66,7 +66,7 @@
 					IN ( SELECT chartdetails.accountcode, chartdetails.period FROM chartdetails )';
 
 		$result = DB_query($sql,$db,$ErrMsg);
-
+*/
 		prnMsg(_('The new general ledger account has been added'),'success');
 	}
 

Modified: trunk/doc/Change.log.html
===================================================================
--- trunk/doc/Change.log.html	2010-06-29 13:24:19 UTC (rev 3534)
+++ trunk/doc/Change.log.html	2010-06-30 09:26:50 UTC (rev 3535)
@@ -1,5 +1,6 @@
 <p><font SIZE=4 COLOR=BLUE><b>webERP Change Log</b></font></p>
 <p></p>
+<p>30/06/10 Phil: Resolution of GL posting problem - removed INSERTs of new chartdetails from DateFunctions.inc CreatePeriod function and GLAccounts.php when adding a new GL account. Now all chartdetails are created from includes/GLPostings.inc and correct bfwd balances updated as they should be - I hope this solves this long outstanding previously unsquashable bug!!
 <p>25/06/10 Tim: PDFPriceList.php - Layout improvements.</p>
 <p>25/06/10 Tim: SelectCompletedOrders.php - Layout improvements.</p>
 <p>25/06/10 Tim: FormDesigner.php - Add A5 to the paper sizes.</p>

Modified: trunk/includes/DateFunctions.inc
===================================================================
--- trunk/includes/DateFunctions.inc	2010-06-29 13:24:19 UTC (rev 3534)
+++ trunk/includes/DateFunctions.inc	2010-06-30 09:26:50 UTC (rev 3535)
@@ -730,14 +730,19 @@
 				$ErrMsg = _('An error occurred in adding a new period number');
 				$GetPrdResult = DB_query($GetPrdSQL, $db, $ErrMsg);
 
+/*I don't think this is necessary since GLPostings.inc handles this
+ * 
 				$sql = 'INSERT INTO chartdetails (accountcode, period)
 						SELECT chartmaster.accountcode, periods.periodno
 							FROM chartmaster
 								CROSS  JOIN periods
 						WHERE ( chartmaster.accountcode, periods.periodno ) NOT
 							IN ( SELECT chartdetails.accountcode, chartdetails.period FROM chartdetails )';
-/*dont trap errors - chart details records created only as required - duplicate messages ignored */
+
+//dont trap errors - chart details records created only as required - duplicate messages ignored 
 				$InsNewChartDetails = DB_query($sql,$db,'','','',false);
+*/
+
 }
 
 function PeriodExists($TransDate, &$db) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.