RE: [Wconsole-devel] Redundant parameter in CFunction
Status: Pre-Alpha
Brought to you by:
abzero
|
From: Dimiter N. <blu...@ne...> - 2002-03-03 20:30:00
|
Hi Evan, Here are the methods and fields from CFunction and CFunctionList classes that I do not use (or can do without), they are mostly redundant: CFunctionList::FindFunctionByModule() - its ont used currently because I search the list directly. Maybe its redundant; CFunctionList::RemoveFunction* (all such 3 routines) - I remove the whole lists when needed (with delete) so no individual function remove is necessary; CFunction::ModuleIndex and CFunction::ModuleName - not used; used only for the log file messages; maybe we'd better could replace them both with a CModule* field that denotes the CModule object; CModuleManager registers a default module "WCONSOLE" that contains all built-in routines (like EXIT,ABOUT,LOAD,UNLOAD,etc.). I've documeneted the way they are registred - as a prototype in common.h, as a func body in wconsole.cpp and as a line in the CModuleManager's constructor. Maybe this is a good solution? Tell me what do you think about that... If there is something obscure in my code, please let me know and I'll fix it! Regards, Dimiter -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey Dimiter, I've been looking over ya code, and its all good :) You seem to add a function list for each module, so wouldn't the Module Index, and Module Name parameters be redundant, and a waste of Memory? Evan, Evan Marchant eva...@bt... -----BEGIN PGP SIGNATURE----- Version: PGPfreeware 7.0.3 for non-commercial use <http://www.pgp.com> iQA/AwUBPIJ8TSi6Rn1gme9zEQLOmACfVyWlPTzbYk+t3Z540ph1/r7BaNwAoI3R a3LiGIi6OcE0NWdjC5MWqi7Q =+cRm -----END PGP SIGNATURE----- _______________________________________________ Wconsole-devel mailing list Wco...@li... https://lists.sourceforge.net/lists/listinfo/wconsole-devel |