From: Wheeler, F. W (Research) <wh...@cr...> - 2003-12-04 15:49:27
|
> -----Original Message----- > From: Ian Scott > Sent: Thursday, December 04, 2003 10:22 AM > To: 'Wheeler, Frederick W (Research)'; VXL Maintainers List (E-mail) > Subject: RE: [Vxl-maintainers] NoDartCoverage files > > > It looks to me like the biggest source of error in the > coverage figure is > the fact that any file that isn't touched at all in the tests > doesn't count > against the coverage. I think raw attempts to improve the > coverage value as > displayed on the dashboard are therefore missing the point. > Instead, we > should target all the files listed at the bottom of the coverage page. So there seems to be 2 issues: 1. Dart should count the completely uncovered files so the coverage stats are accurate 2. We should write tests to cover VXL libraries > As a public service I have categorised the completely uncovered files > > contrib/brl ~275 files > contrib/gel ~300 files > contrib/mul ~180 files > contrib/oxl ~420 files > contrib/rpl ~20 files > contrib/tbl ~60 files > > core/vbl ~50 files > core/vcsl ~65 files > core/vgl ~50 files > core/vgui ~300 files > core/vidl ~20 files > core/vil ~60 files > core/vnl ~110 files > core/vsl ~10 files > core/vul ~20 files > > Now some of those files are .h files containing absolutely no > executable > code (The majority of vsl and vnl are like this.) But if > someone were to > write some tests that at least touched some of these files, > we might get a > more realistic view of our coverage. > > Fred: I'd also suggest adding .NoDartCoverage to the > following, on the basis > that we should not be interested in improving their coverage. > > core/doc > core/testlib > core/vidl_vil1 > core/vil1 > vcl I did this. Thanks. I also added .NoDartCoverage files in all Templates and examples dirs. I'll try them in the tests dirs locally on one of the coverage builds to see what happens. -Fred > > -----Original Message----- > > From: Wheeler, Frederick W (Research) [mailto:wh...@cr...] > > Sent: Thursday, December 04, 2003 1:47 PM > > To: VXL Maintainers List (E-mail) > > Subject: [Vxl-maintainers] NoDartCoverage files > > > > > > VXL Maintainers: > > > > 1. There are a lot of Templates and examples directories that do not > > have a .NoDartCoverage file. I've listed them below. If there's no > > objection, I'll add the .NoDartCoverage files. > > > > 2. None of the tests directories have a .NoDartCoverage file. It > > seems to me that they should. Does anyone know for sure? > The job of > > the tests is to cover the libraries. We really don't care how the > > tests themselves are covered and files there should not be > in the Dart > > coverage report. The tests/ source files are generally 100% > > covered, but > > that is artificially inflating our coverage percentage. > > If nobody knows for sure how this should be done, > > I'll add .NoDartCoverage files in the tests dirs locally on > a coverage > > build to see what happens. > > > > Fred Wheeler > > > > # commands to find which dirs are/are not covered > > > > cd $VXLSRC > > # directories with no .NoDartCoverage file (323) > > find . -type d ! -name CVS \! -exec test -f > > {}/.NoDartCoverage \; -print > > # directories with a .NoDartCoverage file (81) > > find . -type d ! -name CVS -exec test -f {}/.NoDartCoverage > \; -print > > # directories with no .NoDartCoverage file that should have one (32) > > find . -type d ! -name CVS \( -name Templates -o -name > > examples \) \! -exec > > test -f {}/.NoDartCoverage \; -print > > # test dirs with no .NoDartCoverage file (59) > > find . -type d ! -name CVS -name tests \! -exec test -f > > {}/.NoDartCoverage > > \; -print > > > > # dirs that I think should have a .NoDartCoverage > > > > ./contrib/brl/bbas/bdgl/Templates > > ./contrib/brl/bbas/bgui/Templates > > ./contrib/brl/bbas/bsol/Templates > > ./contrib/brl/bbas/bugl/Templates > > ./contrib/brl/bbas/bvgl/Templates > > ./contrib/brl/bbas/bxml/Templates > > ./contrib/brl/bmvl/btom/Templates > > ./contrib/brl/bseg/brip/Templates > > ./contrib/brl/bseg/sdet/Templates > > ./contrib/brl/bseg/strk/Templates > > ./contrib/brl/bseg/vpro/Templates > > ./contrib/gel/gmvl/examples > > ./contrib/gel/gtrl/examples > > ./contrib/gel/pop/examples > > ./contrib/gel/vdgl/examples > > ./contrib/gel/vgel/examples > > ./contrib/gel/vifa/Templates > > ./contrib/gel/vsol/examples > > ./contrib/gel/vsrl/examples > > ./contrib/gel/vtol/examples > > ./contrib/mul/vil3d/algo/Templates > > ./contrib/mul/vimt3d/Templates > > ./contrib/oxl/mvl/examples > > ./contrib/oxl/ogui/examples > > ./contrib/oxl/osl/examples > > ./contrib/rpl/rrel/examples > > ./contrib/tbl/vepl/examples > > ./contrib/tbl/vepl2/examples > > ./contrib/tbl/vipl/examples > > ./core/vil1/examples > > ./core/vnl/examples > > ./v3p/netlib/examples > > > > # test dirs that maybe should have .NoDartCoverage files > > > > ./contrib/brl/bbas/bdgl/tests > > ./contrib/brl/bbas/bsol/tests > > ./contrib/brl/bbas/bugl/tests > > ./contrib/brl/bbas/bvgl/tests > > ./contrib/brl/bbas/bxml/tests > > ./contrib/brl/bmvl/bcal/tests > > ./contrib/brl/bmvl/brct/tests > > ./contrib/brl/bseg/brip/tests > > ./contrib/brl/bseg/tests > > ./contrib/conversions/container/tests > > ./contrib/conversions/geometry/tests > > ./contrib/conversions/image/tests > > ./contrib/conversions/math/tests > > ./contrib/conversions/misc/tests > > ./contrib/gel/gevd/tests > > ./contrib/gel/vdgl/tests > > ./contrib/gel/vifa/tests > > ./contrib/gel/vsol/tests > > ./contrib/gel/vtol/tests > > ./contrib/mul/clsfy/tests > > ./contrib/mul/ipts/tests > > ./contrib/mul/mbl/tests > > ./contrib/mul/mil/tests > > ./contrib/mul/mil3d/tests > > ./contrib/mul/pdf1d/tests > > ./contrib/mul/vil3d/io/tests > > ./contrib/mul/vil3d/tests > > ./contrib/mul/vimt/tests > > ./contrib/mul/vimt3d/tests > > ./contrib/mul/vpdfl/tests > > ./contrib/oxl/ogui/tests > > ./contrib/oxl/osl/tests > > ./contrib/rpl/rrel/tests > > ./contrib/rpl/rsdl/tests > > ./contrib/tbl/vepl/tests > > ./contrib/tbl/vepl2/tests > > ./contrib/tbl/vipl/tests > > ./core/testlib/tests > > ./core/tests > > ./core/vbl/io/tests > > ./core/vbl/tests > > ./core/vcsl/tests > > ./core/vgl/io/tests > > ./core/vgl/tests > > ./core/vgui/tests > > ./core/vidl/tests > > ./core/vidl_vil1/tests > > ./core/vil/io/tests > > ./core/vil/tests > > ./core/vil1/io/tests > > ./core/vil1/tests > > ./core/vnl/io/tests > > ./core/vnl/tests > > ./core/vpl/tests > > ./core/vsl/tests > > ./core/vul/io/tests > > ./core/vul/tests > > ./v3p/netlib/tests > > ./vcl/tests > > > > > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Vxl-maintainers mailing list > Vxl...@li... > https://lists.sourceforge.net/lists/listinfo/vxl-maintainers > |
From: Wheeler, F. W (Research) <wh...@cr...> - 2003-12-08 17:45:04
|
VXL Maintainers: The VXL Dashboard has 2 coverage builds: Linux-2.4.18_gcc-3.2_-Wall_profile_static 64.61% Solaris-2.8_gcc-3.0.4_profile_static 75.97% The Linux build has .NoDartCoverage files in every tests directory in its local copy of the source tree, as a trial. I think this gives a more accurate representation of the test coverage of VXL. We should not count a line of test code as tested code. I'll commit these files in a couple of days if there is no objection in the meantime. Regards, Fred > -----Original Message----- > From: Wheeler, Frederick W (Research) [mailto:wh...@cr...] > Sent: Thursday, December 04, 2003 8:47 AM > To: VXL Maintainers List (E-mail) > Subject: [Vxl-maintainers] NoDartCoverage files > > > VXL Maintainers: > > 1. There are a lot of Templates and examples directories that do not > have a .NoDartCoverage file. I've listed them below. If there's no > objection, I'll add the .NoDartCoverage files. > > 2. None of the tests directories have a .NoDartCoverage file. It > seems to me that they should. Does anyone know for sure? The job of > the tests is to cover the libraries. We really don't care how the > tests themselves are covered and files there should not be in the Dart > coverage report. The tests/ source files are generally 100% > covered, but > that is artificially inflating our coverage percentage. > If nobody knows for sure how this should be done, > I'll add .NoDartCoverage files in the tests dirs locally on a coverage > build to see what happens. > > Fred Wheeler > > # commands to find which dirs are/are not covered > > cd $VXLSRC > # directories with no .NoDartCoverage file (323) > find . -type d ! -name CVS \! -exec test -f > {}/.NoDartCoverage \; -print > # directories with a .NoDartCoverage file (81) > find . -type d ! -name CVS -exec test -f {}/.NoDartCoverage \; -print > # directories with no .NoDartCoverage file that should have one (32) > find . -type d ! -name CVS \( -name Templates -o -name > examples \) \! -exec > test -f {}/.NoDartCoverage \; -print > # test dirs with no .NoDartCoverage file (59) > find . -type d ! -name CVS -name tests \! -exec test -f > {}/.NoDartCoverage > \; -print > > # dirs that I think should have a .NoDartCoverage > > ./contrib/brl/bbas/bdgl/Templates > ./contrib/brl/bbas/bgui/Templates > ./contrib/brl/bbas/bsol/Templates > ./contrib/brl/bbas/bugl/Templates > ./contrib/brl/bbas/bvgl/Templates > ./contrib/brl/bbas/bxml/Templates > ./contrib/brl/bmvl/btom/Templates > ./contrib/brl/bseg/brip/Templates > ./contrib/brl/bseg/sdet/Templates > ./contrib/brl/bseg/strk/Templates > ./contrib/brl/bseg/vpro/Templates > ./contrib/gel/gmvl/examples > ./contrib/gel/gtrl/examples > ./contrib/gel/pop/examples > ./contrib/gel/vdgl/examples > ./contrib/gel/vgel/examples > ./contrib/gel/vifa/Templates > ./contrib/gel/vsol/examples > ./contrib/gel/vsrl/examples > ./contrib/gel/vtol/examples > ./contrib/mul/vil3d/algo/Templates > ./contrib/mul/vimt3d/Templates > ./contrib/oxl/mvl/examples > ./contrib/oxl/ogui/examples > ./contrib/oxl/osl/examples > ./contrib/rpl/rrel/examples > ./contrib/tbl/vepl/examples > ./contrib/tbl/vepl2/examples > ./contrib/tbl/vipl/examples > ./core/vil1/examples > ./core/vnl/examples > ./v3p/netlib/examples > > # test dirs that maybe should have .NoDartCoverage files > > ./contrib/brl/bbas/bdgl/tests > ./contrib/brl/bbas/bsol/tests > ./contrib/brl/bbas/bugl/tests > ./contrib/brl/bbas/bvgl/tests > ./contrib/brl/bbas/bxml/tests > ./contrib/brl/bmvl/bcal/tests > ./contrib/brl/bmvl/brct/tests > ./contrib/brl/bseg/brip/tests > ./contrib/brl/bseg/tests > ./contrib/conversions/container/tests > ./contrib/conversions/geometry/tests > ./contrib/conversions/image/tests > ./contrib/conversions/math/tests > ./contrib/conversions/misc/tests > ./contrib/gel/gevd/tests > ./contrib/gel/vdgl/tests > ./contrib/gel/vifa/tests > ./contrib/gel/vsol/tests > ./contrib/gel/vtol/tests > ./contrib/mul/clsfy/tests > ./contrib/mul/ipts/tests > ./contrib/mul/mbl/tests > ./contrib/mul/mil/tests > ./contrib/mul/mil3d/tests > ./contrib/mul/pdf1d/tests > ./contrib/mul/vil3d/io/tests > ./contrib/mul/vil3d/tests > ./contrib/mul/vimt/tests > ./contrib/mul/vimt3d/tests > ./contrib/mul/vpdfl/tests > ./contrib/oxl/ogui/tests > ./contrib/oxl/osl/tests > ./contrib/rpl/rrel/tests > ./contrib/rpl/rsdl/tests > ./contrib/tbl/vepl/tests > ./contrib/tbl/vepl2/tests > ./contrib/tbl/vipl/tests > ./core/testlib/tests > ./core/tests > ./core/vbl/io/tests > ./core/vbl/tests > ./core/vcsl/tests > ./core/vgl/io/tests > ./core/vgl/tests > ./core/vgui/tests > ./core/vidl/tests > ./core/vidl_vil1/tests > ./core/vil/io/tests > ./core/vil/tests > ./core/vil1/io/tests > ./core/vil1/tests > ./core/vnl/io/tests > ./core/vnl/tests > ./core/vpl/tests > ./core/vsl/tests > ./core/vul/io/tests > ./core/vul/tests > ./v3p/netlib/tests > ./vcl/tests > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Vxl-maintainers mailing list > Vxl...@li... > https://lists.sourceforge.net/lists/listinfo/vxl-maintainers > |