From: Peter V. <Pet...@es...> - 2003-08-12 21:02:53
|
> --- vil_corners.cxx 4 Jul 2003 09:21:26 -0000 1.2 > +++ vil_corners.cxx 12 Aug 2003 18:30:10 -0000 1.3 > @@ -56,6 +56,6 @@ > const vcl_ptrdiff_t oj2 = grad_j.jstep(); > const vcl_ptrdiff_t oj3 = grad_j.istep() + grad_j.jstep(); > - const vcl_ptrdiff_t oj4 = -grad_j.istep(); > - const vcl_ptrdiff_t oj5 = grad_j.istep(); > + //const vcl_ptrdiff_t oj4 = -grad_j.istep(); // unused > + //const vcl_ptrdiff_t oj5 = grad_j.istep(); // unused > const vcl_ptrdiff_t oj6 = -grad_j.istep() - grad_j.jstep(); > const vcl_ptrdiff_t oj7 = -grad_j.jstep(); It looks a bit suspicious that oj4 and oj5 are unused. Any comments from anybody? -- Peter. |
From: Ian S. <ian...@st...> - 2003-08-13 20:25:45
|
Tim wrote that code, but is off on holiday for a while. I'll let him know when he gets back. Ian. > -----Original Message----- > From: Peter Vanroose [mailto:Pet...@es...] > Sent: Tuesday, August 12, 2003 9:55 PM > To: ami...@us... > Cc: vxl...@li... > Subject: [Vxl-maintainers] vxl/core/vil/algo/vil_corners.cxx unused > variables > > > > --- vil_corners.cxx 4 Jul 2003 09:21:26 -0000 1.2 > > +++ vil_corners.cxx 12 Aug 2003 18:30:10 -0000 1.3 > > @@ -56,6 +56,6 @@ > > const vcl_ptrdiff_t oj2 = grad_j.jstep(); > > const vcl_ptrdiff_t oj3 = grad_j.istep() + grad_j.jstep(); > > - const vcl_ptrdiff_t oj4 = -grad_j.istep(); > > - const vcl_ptrdiff_t oj5 = grad_j.istep(); > > + //const vcl_ptrdiff_t oj4 = -grad_j.istep(); // unused > > + //const vcl_ptrdiff_t oj5 = grad_j.istep(); // unused > > const vcl_ptrdiff_t oj6 = -grad_j.istep() - grad_j.jstep(); > > const vcl_ptrdiff_t oj7 = -grad_j.jstep(); > > > It looks a bit suspicious that oj4 and oj5 are unused. > Any comments from anybody? > > > -- Peter. > > > ------------------------------------------------------- > This SF.Net email sponsored by: Free pre-built ASP.NET sites including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet > _072303_01/01 > _______________________________________________ > Vxl-maintainers mailing list > Vxl...@li... > https://lists.sourceforge.net/lists/listinfo/vxl-maintainers > |
From: Tim C. <Tim...@ma...> - 2003-08-15 09:02:49
|
Peter Vanroose wrote: >>--- vil_corners.cxx 4 Jul 2003 09:21:26 -0000 1.2 >>+++ vil_corners.cxx 12 Aug 2003 18:30:10 -0000 1.3 >>@@ -56,6 +56,6 @@ >> const vcl_ptrdiff_t oj2 = grad_j.jstep(); >> const vcl_ptrdiff_t oj3 = grad_j.istep() + grad_j.jstep(); >>- const vcl_ptrdiff_t oj4 = -grad_j.istep(); >>- const vcl_ptrdiff_t oj5 = grad_j.istep(); >>+ //const vcl_ptrdiff_t oj4 = -grad_j.istep(); // unused >>+ //const vcl_ptrdiff_t oj5 = grad_j.istep(); // unused >> const vcl_ptrdiff_t oj6 = -grad_j.istep() - grad_j.jstep(); >> const vcl_ptrdiff_t oj7 = -grad_j.jstep(); >> >> > > >It looks a bit suspicious that oj4 and oj5 are unused. >Any comments from anybody? > > The code is estimating second derivatives by passing a sobel operator over a pair of derivative images (assumed to have been created by a sobel pass of a raw image). Due to various symmetries, d2I/dxdy == d2I/dydx, so we need only compute the y derivatives of the dx image. Thus oj4,oj5 were not used. I've now removed them. Tim > > -- Tim Cootes Senior Lecturer Imaging Science and Biomedical Engineering tel (+44) 0161 275 5146 The University of Manchester fax (+44) 0161 275 5145 Manchester M13 9PT , UK mailto:t.c...@ma... http://www.isbe.man.ac.uk/~bim |