From: Nicolas B. <nic...@en...> - 2005-07-25 22:23:44
Attachments:
install_target.patch
|
Hi, Now that the release process seems stopped, I think it's time for me to submit a rather big but simple patch adding an install target to Vxl. Basically I've just added INSTALL_NOBASE_HEADER_FILES directives into every CMakeLists.txt, with a little trick to extract the .h and .h.in files from the _sources variables already defined, keeping the directory tree. The name is inspired by automake's nobase_HEADERS directive. Two new files have been created : config/cmake/config/vxl_utils.cmake to hold the new macro, and config/cmake/Modules/VXLConfig_export.cmake.in to create a $install_dir/share/vxl/cmake/VXLConfig.cmake at install time. This allows Cmake'ified projects to use an installed version of Vxl easily. The patch is attached to this email, I will commit it if approved. Here is a typical usecase: $ mkdir /tmp/build && cd /tmp/build $ ccmake -DCMAKE_INSTALL_PREFIX=/opt/vxl $vxl_source_dir $ make $ make install $ cd /tmp/example $ cat CMakeLists.txt FIND_PACKAGE(VXL) IF(VXL_FOUND) INCLUDE(${VXL_CMAKE_DIR}/UseVXL.cmake) ENDIF(VXL_FOUND) LINK_LIBRARIES( vil vcl ) ADD_EXECUTABLE( vil_example example.cxx ) $ ccmake -DVXL_DIR=/opt/vxl/share/vxl/cmake . $ make $ ./vil_example Please let me know what you think. -- Nicolas Burrus |
From: Amitha P. <pe...@cs...> - 2005-07-26 13:40:52
|
Hi Nicolas I glanced over the patch, and it seems reasonable. I assume you've tested it on your platform. I assume that there is magic somewhere that will copy a generated header file from the binary directory when it cannot be found in the source directory. If others don't object, I'd say commit it and see what the dashboards say. I would ask, though, that you subscribe to and monitor vxl-maintainers, so that we can easily discuss any issues arising from the changes. Thanks for your work on this! With more frequent releases, and with the ability to "install", perhaps it'll be easier for folks to use VXL. Amitha. |
From: Nicolas B. <nic...@en...> - 2005-07-26 14:00:47
|
On Tuesday 26 July 2005 15:40, Amitha Perera wrote: > Hi Nicolas > > I glanced over the patch, and it seems reasonable. I assume you've > tested it on your platform. Sure > I assume that there is magic somewhere that will copy a generated > header file from the binary directory when it cannot be found in the > source directory. Actually, Cmake does the job itself, when a INSTALL_FILES directive is specified, it looks for files into the corresponding build directory if it cannot find it in the source directory. > If others don't object, I'd say commit it and see what the dashboards > say. Ok, I will wait for some other comments. > I would ask, though, that you subscribe to and monitor > vxl-maintainers, so that we can easily discuss any issues arising > from the changes. I've already suscribed, but I'm not posting with my subscription email address. > Thanks for your work on this! With more frequent releases, and > with the ability to "install", perhaps it'll be easier for folks to > use VXL. I also hope it will make it easier to create packages, since Cmake already supports the DESTDIR variable for the install target. Thanks for your feedback ! -- Nicolas Burrus |
From: Nicolas B. <nic...@la...> - 2005-09-30 07:43:38
|
On Tuesday 26 July 2005 15:58, Nicolas Burrus wrote: > On Tuesday 26 July 2005 15:40, Amitha Perera wrote: > > Hi Nicolas > > > > I glanced over the patch, and it seems reasonable. I assume you've > > tested it on your platform. > > Sure > > > I assume that there is magic somewhere that will copy a generated > > header file from the binary directory when it cannot be found in the > > source directory. > > Actually, Cmake does the job itself, when a INSTALL_FILES directive is > specified, it looks for files into the corresponding build directory if it > cannot find it in the source directory. > > > If others don't object, I'd say commit it and see what the dashboards > > say. > > Ok, I will wait for some other comments. Well, I guess there won't be any objection now, and I've been using the INSTALL target for 2 months, so I will commit it soon. |