#38 Invalid start time caught, but not reported

Version 2.3.x
open
Andre M
5
2009-04-14
2009-03-26
No

If you create an event, but have the start time later than the stop time, when you click "Preview Event" nothing happens - that is the page reloads unchanged.

I believe you should remove the checkeventtime() call from checkevent(). The Preview Window will show a red message about the time if it is wrong so checking it here is not necessary. Either that or report the time error here.

This is version 2.3.0.505, sorry I do not have test environment to see if this bug is in the latest release.

Thank you.

Discussion

  • Andre M

    Andre M - 2009-04-08
    • milestone: --> Version 2.3.x
    • assigned_to: nobody --> amekkawi
    • status: open --> closed-fixed
     
  • Andre M

    Andre M - 2009-04-08

    The error message now displays on the form above the time drop-downs.

     
  • Charles Hall

    Charles Hall - 2009-04-14

    Pardon the question, but I'm new to the way Sourceforge projects work... I don't see this fix in RC-REV550. When should I expect to see bug fixes show up in a release candidate? Or should I be accessing some sort of developer source code work area to get the absolute latest version?

     
  • Andre M

    Andre M - 2009-04-14
    • status: closed-fixed --> open
     
  • Charles Hall

    Charles Hall - 2009-04-15

    Perhaps you misunderstood. Follow these steps:
    1 Add a new event
    2 Click Timed Event 8PM - 7PM (invalid time)
    3 Pick any category
    4 Add a title
    5 Click "Preview Event"

    Nothing changes. There is no error message, no preview. This is under PHP4 with RC-Rev550.

     
  • Charles Hall

    Charles Hall - 2009-04-21

    I see your attempted patch in Rev550, but you have a typo. At line 331 (or thereabouts) in functions-inputdata-event.inc.php you have this line:

    if ($inputrequired && $check && !$defaultButtonPressed && $event['wholedayevent'] != 0) {

    This invokes an error check on start & stop times ONLY FOR WHOLE DAY events! You meant to put a "==0" at the end of that conditional, not "!=0". Or so it appears.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks