Menu
▾
▴
#38 Invalid start time caught, but not reported
If you create an event, but have the start time later than the stop time, when you click "Preview Event" nothing happens - that is the page reloads unchanged.
I believe you should remove the checkeventtime() call from checkevent(). The Preview Window will show a red message about the time if it is wrong so checking it here is not necessary. Either that or report the time error here.
This is version 2.3.0.505, sorry I do not have test environment to see if this bug is in the latest release.
Thank you.
The error message now displays on the form above the time drop-downs.
Pardon the question, but I'm new to the way Sourceforge projects work... I don't see this fix in RC-REV550. When should I expect to see bug fixes show up in a release candidate? Or should I be accessing some sort of developer source code work area to get the absolute latest version?
Perhaps you misunderstood. Follow these steps:
1 Add a new event
2 Click Timed Event 8PM - 7PM (invalid time)
3 Pick any category
4 Add a title
5 Click "Preview Event"
Nothing changes. There is no error message, no preview. This is under PHP4 with RC-Rev550.
I see your attempted patch in Rev550, but you have a typo. At line 331 (or thereabouts) in functions-inputdata-event.inc.php you have this line:
if ($inputrequired && $check && !$defaultButtonPressed && $event['wholedayevent'] != 0) {
This invokes an error check on start & stop times ONLY FOR WHOLE DAY events! You meant to put a "==0" at the end of that conditional, not "!=0". Or so it appears.
You're right! I had caught this logic error but I did my testing outside my normal dev environment and had not correctly ported it back to my normal dev environment before committing the change to the code repository.
The change is now in revision 574. I've been working on the new version of VTCalendar, hence the sudden jump in the revision number.
This is a change that will appear in the final release (or possibly a release candidate 2, if enough bugs are discovered).
If you want to see the most recent changes to VTCalendar, you can access the source repository directly at http://vtcalendar.svn.sourceforge.net/viewvc/vtcalendar/trunk/ and you can download a TAR of the files at http://vtcalendar.svn.sourceforge.net/viewvc/vtcalendar/trunk.tar.gz?view=tar.
If you want to download just this one file it's available at http://vtcalendar.svn.sourceforge.net/viewvc/vtcalendar/trunk/functions-inputdata-event.inc.php?revision=574&pathrev=574
Please let me know if this works for you. Thanks!