Re: [vpopmail-devel] ONCHANGE fixes for 5.4.19 (and for qmailadmin)

[Rick W. <vc...@de...>]

John Simpson wrote:
> also, the call_onchange() function itself now returns whatever the 
> return value from the "onchange" script was. right now it's useless, but 
> if some future code needs to know the return value from the script, the 
> information is now available.

I Like that.


> http://qmail.jms1.net/patches/vpopmail-5.4.19-onchange-fix.patch is the 
> direct URL to the patch file itself.
> 
> i fully expect somebody to find a typo or a bug in the patch, although 
> i'm running it on my own server with no ill effects.

It looks good to me.  It is in CVS, and if you are happy with it, and I 
don't hear any problems from Bill Shupp, I'll release 5.4.20 as stable.




> in addition, i have written an "onchange" patch for qmailadmin.

I saw that on the list, and plan to add it as soon as I find out if Tom 
still wants exclusive access to the qmailadmin cvs.


Rick


p.s.  Unless you can give me a concrete example where you need to edit 
ordered aliases, I plan to start on aliasReplace() right after the 
stable release.  You either use the existing set of alias calls to 
manage a list of addresses, or you call aliasReplace to store the entire 
contents of the alias at once.

aliasReplace( Domain, Alias, Contents );

Contents is an array of strings that make up the alias.  I can't think 
of any uses where you need an ordered alias.  I see more use for merging 
parameters into a template, then storing the entire result in one step.

Besides it is so much easier to code for cdb and databases and whatever 
else if I don't have to expose the sequence mechanism to mere mortals.  :)