Re: [VirtualGL-Devel] Clarify glx pixmap unit test description

[Nathan K. <nat...@sp...>]

On 12/03/15 12:09 AM, DRC wrote:
> It's sort of pedantic.  The assumption is that, in the first three 
> tests, the Pixmap is 3D, because it isn't meaningful to test XCopyArea() 
> otherwise (2D->2D would pass through to X11 without VirtualGL's 
> interference.)  I don't have any real problem changing this, but I think 
> the first two (Window->Pixmap and Pixmap->Window) should be changed as well.

Right. Updated in attached patch:

We go from:

			printf("Pixmap->Window:                 ");
			printf("Window->Pixmap:                 ");
			printf("Pixmap->Pixmap:                 ");
			printf("GLX Pixmap->2D Pixmap:          ");
			printf("Deleted GLX Pixmap->2D Pixmap:  ");


To:

			printf("GLX Pixmap->Window:             ");
			printf("Window->GLX Pixmap:             ");
			printf("GLX Pixmap->GLX Pixmap:         ");
			printf("GLX Pixmap->2D Pixmap:          ");
			printf("Deleted GLX Pixmap->2D Pixmap:  ");


The pedantry originated from one point where I'd wasted time checking
if there was some nuance to why ealier tests said just "Pixmap" and
later tests said "GLX Pixmap".

-Nathan