This patch updates "doc/building/Windows-MinGW-GTK3-Howto.txt".
I added the FFMPEG package to the list. That means that we can configure VICE with --enable-external-ffmpeg instead of --enable-static-lame --enable-static-ffmpeg.
I have a few issues/nitpicks though, I'll go through them:
-Use your favourite editor to change your home dir entry in /etc/passwd:
+Use your favourite editor to change your home dir. entry in /etc/passwd:
Why the dot? 'dir' is a perfectly acceptable abbreviation of 'directory' and if you want 'directory' written out it still fits in 80 columns.
Another 'issue' is the removal of the instructions about changing mirrors. I understand we're not the ones to explain how to use msys2, but perhaps we could move those instructions down to the end of the document and provide a hint ("look at 12.") and then describe the mirror stuff there?
requires a restart of the shell. This is not an issue with your patch, the original document is missing this information. So this is a reminder for myself to add that info.
Finally, something that's probably my personal preference:
I'd like to be explicit. I know VICE will configure fine for the Gtk3 UI with the proper libs installed. but what if we decide to remove the 'gtk3 -> sdl2 -> sdl1' UI auto-selection?
And since you're using make -s (which is nice), perhaps we should also add --no-print-dir , which would remove all the 'entering'/'leaving' messages?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
-Use your favourite editor to change your home dir entry in /etc/passwd:
+Use your favourite editor to change your home dir. entry in /etc/passwd:
Why the dot? 'dir' is a perfectly acceptable abbreviation of 'directory'; and if you want 'directory' written out, it still fits in 80 columns.
It's a syntax tradition that I like. It says, "this definitely is an abbreviation". For example,
direct is a word, while
direct. is an abbreviation of a longer word.
Another 'issue' is the removal of the instructions about changing mirrors. I understand we're not the ones to explain how to use msys2, but perhaps we could move those instructions down to the end of the document, and provide a hint ("look at 12."), and then describe the mirror stuff there?
The mirror URL files have changed several times since you wrote those instructions. The "msys2.org" URL even was removed. I thought that they were no longer relevant. I wasn't aware that the URL has been put back in. Now, I have put your instructions back in.
This:
+Also, add this line to your "~/.bashprofile" file:
+export OSTYPE="MSYS"
requires a restart of the shell. This is not an issue with your patch, the original document is missing this information. So, this is a reminder for myself to add that info.
Finally, something that's probably my personal preference:
I'd like to be explicit. I know VICE will configure fine for the Gtk3 UI with the proper libs installed. but what if we decide to remove the 'gtk3 -> sdl2 -> sdl1' UI auto-selection?
OK, I put that back into the file.
And, since you're using make -s (which is nice), perhaps we should also add --no-print-dir , which would remove all the 'entering'/'leaving' messages?
On my system, -s does --no-print-dir. I see only lines like these:
Making all in src
Making all in resid
Making all in resid-dtv
Making all in samplerdrv
Making all in joyport
I agree, some words have such know abbreviations we don't add a dot. One of those would be dir for directory, and indeed a similar issue is with "file name" turning into "filename".
In my language we even have something called the 'English disease', putting spaces between words.
Anyway, 'dir.' is ridiculous.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks for the patch.
I have a few issues/nitpicks though, I'll go through them:
Why the dot? 'dir' is a perfectly acceptable abbreviation of 'directory' and if you want 'directory' written out it still fits in 80 columns.
Another 'issue' is the removal of the instructions about changing mirrors. I understand we're not the ones to explain how to use msys2, but perhaps we could move those instructions down to the end of the document and provide a hint ("look at 12.") and then describe the mirror stuff there?
This:
requires a restart of the shell. This is not an issue with your patch, the original document is missing this information. So this is a reminder for myself to add that info.
Finally, something that's probably my personal preference:
I'd like to be explicit. I know VICE will configure fine for the Gtk3 UI with the proper libs installed. but what if we decide to remove the 'gtk3 -> sdl2 -> sdl1' UI auto-selection?
And since you're using
make -s(which is nice), perhaps we should also add--no-print-dir, which would remove all the 'entering'/'leaving' messages?It's a syntax tradition that I like. It says, "this definitely is an abbreviation". For example,
direct is a word, while
direct. is an abbreviation of a longer word.
The mirror URL files have changed several times since you wrote those instructions. The "msys2.org" URL even was removed. I thought that they were no longer relevant. I wasn't aware that the URL has been put back in. Now, I have put your instructions back in.
OK, I put that back into the file.
On my system,
-sdoes--no-print-dir. I see only lines like these:Last edit: Greg King 2021-04-09
Oh, I assume 'Windowss' is a typo?
=)
I think that if the rest of the existing document doesn't use that syntax tradition then you shouldn't introduce it in one small place.
Regarding "dir" though, I think it is common enough that it has become a word itself, like "filename"
edit: whoops replied to wrong thing
Last edit: dqh 2021-04-09
I agree, some words have such know abbreviations we don't add a dot. One of those would be dir for directory, and indeed a similar issue is with "file name" turning into "filename".
In my language we even have something called the 'English disease', putting spaces between words.
Anyway, 'dir.' is ridiculous.
just wait until you update "make" further :)
applied in r39934